You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/20 12:51:44 UTC

[GitHub] [spark] LuciferYang opened a new pull request #35582: [SPARK-38260][BUILD] Delete direct Maven dependency on `commons-net`

LuciferYang opened a new pull request #35582:
URL: https://github.com/apache/spark/pull/35582


   ### What changes were proposed in this pull request?
   [SPARK-1189](https://github.com/apache/spark/pull/33/files)  introduces maven dependence on `commons-net`, and `org.apache.commons.net.util.Base64` is used in `SparkSaslServer`,  but `SparkSaslServer` has changed to use `io.netty.handler.codec.base64.Base64` and there is no explicit dependency on `commons-net` in Spark code, so this pr removed this dependency.
   
   After this pr Spark with `hadoop-3` profile no longer need `commons-net`, but Spark with `hadoop-2` still need it due to `hadoop-2.7.4` use `commons-net` directly.
   
   ### Why are the changes needed?
   Remove unnecessary maven dependency.
   
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   `commons-net` jar no longer exists in Spark-Client with hadoop-3.x 
   
   
   
   
   ### How was this patch tested?
   Pass GA
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dongjoon-hyun closed pull request #35582: [SPARK-38260][BUILD][CORE] Remove `commons-net` dependency in `hadoop-3` profile

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35582:
URL: https://github.com/apache/spark/pull/35582


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] LuciferYang commented on pull request #35582: [SPARK-38260][BUILD][CORE] Remove `commons-net` dependency in `hadoop-3` profile

Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35582:
URL: https://github.com/apache/spark/pull/35582#issuecomment-1048406119


   thanks @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org