[GitHub] [airflow] jaketf edited a comment on issue #5602: [AIRFLOW-4983] Feature/dataflow operator python3

[GitBox <gi...@apache.org>]

jaketf edited a comment on issue #5602: [AIRFLOW-4983] Feature/dataflow operator python3
URL: https://github.com/apache/airflow/pull/5602#issuecomment-515601209
 
 
   @potiuk @yk5 PTAL at [dbe5d76](https://github.com/apache/airflow/pull/5602/commits/dbe6d76a0db798b416c6268f717a0ed6fe3be07d).
   
   I'm going back and forth on which of following two makes more sense:
   
   1. Preserve the behavior / tests of the `mlengine_operator_utils.py` (in hard coding  `py_interpreter=python2` in the `DataFlowPythonOperator` instantiation).
   1. Let the util omit `mlengine_operator_utils.py` from `DataFlowPythonOperator` and change the `test_mlengine_operator_utils` to assert that the hook was called w/ the system's python major version. This is more in the spirit of this PR in preparation for python2 deprecation BUT the `mlengine_prediction_summary.py` will give the following warning message from beam if invoked w/ python3 interpreter which may be concerning to the users of this operator:
   ```
   UserWarning: Running the Apache Beam SDK on Python 3 is not yet fully supported. You may encounter buggy behavior or missing features.
   ```
   @tvalentyn will this message be removed in `beam>=2.14.0`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services