[jira] [Commented] (CALCITE-2090) Extend Druid Range Rules to extract interval from Floor

["Nishant Bangarwa (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322658#comment-16322658 ] 

Nishant Bangarwa commented on CALCITE-2090:
-------------------------------------------

[~julianhyde] submitted a PR for this change - https://github.com/apache/calcite/pull/603 . Please review. 

Also fixed couple of more issues found during testing -
# DateRangeRules getting into infinite loop when comparing against invalid month/day. e.g extract(month from ts) = 15
# Month/Day was replaced incorrectly when extract on YEAR resulted in unbounded timerange. e.g extract(YEAR from ts) > 2010 AND extract(Month from ts) = 5, in this case since the year is not bounded, we cannot replace the extract on month.
# Fixed issues with rewriting when we have multiple time operands in filter.

Created a single PR for the fixes as they were in same area. Let me know if you need to create separate PR or file separate issues for the bugs fixed. 

> Extend Druid Range Rules to extract interval from Floor
> -------------------------------------------------------
>
>                 Key: CALCITE-2090
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2090
>             Project: Calcite
>          Issue Type: Improvement
>          Components: druid
>            Reporter: Nishant Bangarwa
>            Assignee: Nishant Bangarwa
>
> DruidRangeRules currently only extracts intervals from EXTRACT function. 
> This task is to enhance Druid Range Rules to also support Floor functions. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)