[GitHub] [incubator-pinot] sunny209868 commented on a change in pull request #4382: Fix java client connection close

[GitBox <gi...@apache.org>]

sunny209868 commented on a change in pull request #4382: Fix java client connection close
URL: https://github.com/apache/incubator-pinot/pull/4382#discussion_r298982745
 
 

 ##########
 File path: pinot-api/src/main/java/org/apache/pinot/client/Connection.java
 ##########
 @@ -156,4 +157,13 @@ public ResultSetGroup get(long timeout, TimeUnit unit)
       return new ResultSetGroup(response);
     }
   }
+
+  /**
+   * connection close.
+   */
+  public void close() {
+    if(Objects.nonNull(_transport)) {
+      System.exit(0);
 
 Review comment:
   Yes, So I put the deleted, in JsonAsyncHttpPinotClientTransport class increased the close method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org