[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #983: Convert date and timestamp values in generics

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #983:
URL: https://github.com/apache/incubator-iceberg/pull/983#discussion_r417465942



##########
File path: data/src/test/java/org/apache/iceberg/data/TestLocalScan.java
##########
@@ -449,6 +454,45 @@ private DataFile writeFile(String location, String filename, List<Record> record
     }
   }
 
+  @Test
+  public void testFilterWithComplexType() throws IOException {
+    if (format == FileFormat.PARQUET) {

Review comment:
       Tests should be disabled using `Assume`, so it doesn't look like they are passing and are skipped instead.
   
   I think it makes sense to only disable the parts of the test that don't pass in Parquet -- I think just the timestamp without zone type. Can you separate that into a different case and add the assume to that one?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org