You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2014/11/07 04:46:27 UTC
[03/29] isis git commit: ISIS-537 Fix JavaScript for
org.apache.isis.viewer.wicket.ui.components.widgets.cssmenu.AjaxDeferredBehaviour.OpenUrlStrategy#NEW_WINDOW.
It should be wrapped in a function.
ISIS-537 Fix JavaScript for org.apache.isis.viewer.wicket.ui.components.widgets.cssmenu.AjaxDeferredBehaviour.OpenUrlStrategy#NEW_WINDOW. It should be wrapped in a function.
https://trello.com/c/UYl51kIt/101-todoitem-opensourcecodeongithub-a-no-arg-action-returning-a-java-net-url-does-nothing
Project: http://git-wip-us.apache.org/repos/asf/isis/repo
Commit: http://git-wip-us.apache.org/repos/asf/isis/commit/cf910f3c
Tree: http://git-wip-us.apache.org/repos/asf/isis/tree/cf910f3c
Diff: http://git-wip-us.apache.org/repos/asf/isis/diff/cf910f3c
Branch: refs/heads/ISIS-939
Commit: cf910f3c9b7f4d613668cf4e104eb0fd9df3e742
Parents: b97fac4
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Tue Nov 4 22:54:10 2014 +0200
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Tue Nov 4 22:54:10 2014 +0200
----------------------------------------------------------------------
.../ui/components/widgets/cssmenu/AjaxDeferredBehaviour.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/isis/blob/cf910f3c/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/cssmenu/AjaxDeferredBehaviour.java
----------------------------------------------------------------------
diff --git a/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/cssmenu/AjaxDeferredBehaviour.java b/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/cssmenu/AjaxDeferredBehaviour.java
index bc9bb2f..cdf06ca 100644
--- a/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/cssmenu/AjaxDeferredBehaviour.java
+++ b/component/viewer/wicket/ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/cssmenu/AjaxDeferredBehaviour.java
@@ -39,7 +39,7 @@ public abstract class AjaxDeferredBehaviour extends AbstractAjaxBehavior {
final RequestCycle requestCycle = deferredBehaviour.getComponent().getRequestCycle();
final UrlRenderer urlRenderer = requestCycle.getUrlRenderer();
String fullUrl = urlRenderer.renderFullUrl(parsedUrl);
- return "Wicket.Event.publish(Isis.Topic.OPEN_IN_NEW_TAB, '" + fullUrl + "');";
+ return "function(){Wicket.Event.publish(Isis.Topic.OPEN_IN_NEW_TAB, '" + fullUrl + "');}";
}
},
SAME_WINDOW {