You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "aminghadersohi (via GitHub)" <gi...@apache.org> on 2026/05/08 06:16:12 UTC
[PR] fix(tests): prevent SemanticLayerModal test from hanging indefinitely [superset]
aminghadersohi opened a new pull request, #39956:
URL: https://github.com/apache/superset/pull/39956
## Summary
- The SemanticLayerModal test introduced in #37815 hangs forever, causing shard 6 of the frontend test suite to time out after 3+ hours
- The test uses fake timers to control a debounce, but our test environment patches out MessageChannel (to work around an rc-overflow issue). Without MessageChannel, React falls back to setTimeout for scheduling renders — and fake timers block those too, so React never re-renders and the test never finishes
- Fix: tell Jest to auto-advance fake timers (advanceTimers: true), which unblocks React's render scheduling while still letting the test explicitly control the 500ms debounce
- Also reorder the DatasetList.test.tsx cleanup to restore real timers before flushing async work, so a test failure mid-run can't cause the same kind of hang
## Test plan
- [x] SemanticLayerModal.test.tsx passes in ~14s (was hanging indefinitely)
- [x] All 28 DatasetList.test.tsx tests pass
- [ ] Shard 6/8 completes in CI without timeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(tests): prevent SemanticLayerModal test from hanging indefinitely [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39956:
URL: https://github.com/apache/superset/pull/39956#issuecomment-4403947135
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(tests): prevent SemanticLayerModal test from hanging indefinitely [superset]
Posted by "aminghadersohi (via GitHub)" <gi...@apache.org>.
aminghadersohi closed pull request #39956: fix(tests): prevent SemanticLayerModal test from hanging indefinitely
URL: https://github.com/apache/superset/pull/39956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org