[GitHub] [madlib] kaknikhil commented on issue #451: DL: Update evaluate and predict for multi model outputs

[GitBox <gi...@apache.org>]

kaknikhil commented on issue #451: DL: Update evaluate and predict for multi model outputs
URL: https://github.com/apache/madlib/pull/451#issuecomment-545565921
 
 
   LGTM, left a few minor follow up comments. When you squash all the commits, just make sure that the commit message is verbose and explains the following
   1. why we removed image count from the multi model agg state and also had to add a final function
   1. motivation for removing json.dumps

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services