[GitHub] [hudi] alexeykudinkin commented on a diff in pull request #6550: [HUDI-4691] Cleaning up duplicated classes in Spark 3.3 module

[GitBox <gi...@apache.org>]

alexeykudinkin commented on code in PR #6550:
URL: https://github.com/apache/hudi/pull/6550#discussion_r961146315


##########
hudi-utilities/pom.xml:
##########
@@ -91,25 +91,11 @@
       <scope>test</scope>
     </dependency>
 
-    <!-- Hoodie -->
-    <dependency>

Review Comment:
   These are not necessary -- we can just depend on the terminal "hudi_spark" module 



##########
packaging/hudi-integ-test-bundle/pom.xml:
##########
@@ -438,45 +438,76 @@
       <version>2.7.4</version>
     </dependency>
 
+    <!-- Hoodie - Spark -->
+
     <dependency>
       <groupId>org.apache.hudi</groupId>
-      <artifactId>hudi-common</artifactId>
+      <artifactId>hudi-spark_${scala.binary.version}</artifactId>

Review Comment:
   GH really weirdly shows re-ordering of some of these.
   
   Changes:
    - Removed unnecessary deps (see comment above)
    - Re-ordered Spark deps to be grouped together (for easier discovery)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org