[GitHub] Ngone51 commented on a change in pull request #23355: [SPARK-26418][SHUFFLE] Only OpenBlocks without any ChunkFetch for one stream will cause memory leak in ExternalShuffleService

[GitBox <gi...@apache.org>]

Ngone51 commented on a change in pull request #23355: [SPARK-26418][SHUFFLE] Only OpenBlocks without any ChunkFetch for one stream will cause memory leak in ExternalShuffleService
URL: https://github.com/apache/spark/pull/23355#discussion_r244445609
 
 

 ##########
 File path: common/network-common/src/main/java/org/apache/spark/network/server/ChunkFetchRequestHandler.java
 ##########
 @@ -90,7 +90,6 @@ protected void channelRead0(
     ManagedBuffer buf;
     try {
       streamManager.checkAuthorization(client, msg.streamChunkId.streamId);
-      streamManager.registerChannel(channel, msg.streamChunkId.streamId);
 
 Review comment:
   I think if you remove this, you should add it back to `NettyBlockRpcServer` for non external shuffle service. Otherwise, you'll introduce the bug you fixed with pr to the non external shuffle service.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org