You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/05/10 13:00:48 UTC
[GitHub] [netbeans] ebarboni opened a new pull request, #4096: change default integration test goal action mapping to failsafe
ebarboni opened a new pull request, #4096:
URL: https://github.com/apache/netbeans/pull/4096
This can be a fix for #4089 with the option to change de default action mapping for integration test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4096: change default integration test goal action mapping to failsafe
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4096:
URL: https://github.com/apache/netbeans/pull/4096#issuecomment-1126822585
I also tested a build based on this PR and running an integration test from a clean checkout fails now, as core goals are skipped (in my case package). Integration tests are run _after_ package (see https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#Lifecycle_Reference). With the current implementation the full maven cycle will be run and then the single integration test is run, with this PR most of the maven cycle is skipped. This is faster, but for me results in broken tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #4096: change default integration test goal action mapping to failsafe
Posted by GitBox <gi...@apache.org>.
ebarboni commented on PR #4096:
URL: https://github.com/apache/netbeans/pull/4096#issuecomment-1127664632
@matthiasblaesing @neilcsmith-net I changed the pre-goal of failsafe:integration-test to "pre-integration-test" as we have the
process-test-classes of surefire:test according to https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#Lifecycle_Reference ( I take the previous phase) .
I agree this only hotfix the issue. The menu on file propose test file and debug test file are enabled we should either edit the pom to add failsafe or disable the menuitem file are not "valid"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni merged pull request #4096: change default integration test goal action mapping to failsafe
Posted by GitBox <gi...@apache.org>.
ebarboni merged PR #4096:
URL: https://github.com/apache/netbeans/pull/4096
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4096: change default integration test goal action mapping to failsafe
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4096:
URL: https://github.com/apache/netbeans/pull/4096#issuecomment-1126735907
@matthiasblaesing surely the same argument could be made for the default unit test action? Which I assume actually got triggered for integration tests in NB13 as well? It seems to be a regression that this does nothing in NB14.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4096: change default integration test goal action mapping to failsafe
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4096:
URL: https://github.com/apache/netbeans/pull/4096#issuecomment-1126741023
@neilcsmith-net not sure what you want to tell me.
Maven has a default binding of `surefire:test` to `test`. The same is not true for integration tests, but goals for integration tests and their verification do exist. As a developer you can tie into them or don't. Failsafe is very explicit that you have to configure it. If you don't do it, your project is broken. The change will at least break setups where people correctly setup their systems and don't use failsafe, but something different (the goal is changed).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4096: change default integration test goal action mapping to failsafe
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4096:
URL: https://github.com/apache/netbeans/pull/4096#issuecomment-1126784851
@matthiasblaesing that _NetBeans_ has a default binding explicitly to `surefire:test` in the run single test actions. While NB13 isn't correct in using that for integration tests, I think the goal should probably still be explicit. Are the default action properties correct to work with another IT plugin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4096: change default integration test goal action mapping to failsafe
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4096:
URL: https://github.com/apache/netbeans/pull/4096#issuecomment-1126773239
So I tested in NB13 and it is not a regression. NB 13 executed integration tests as unittests, which for trivial cases looks as if it works, but immediately breaks down for complex cases. I added a longer version to the original issue, including a potential improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4096: change default integration test goal action mapping to failsafe
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4096:
URL: https://github.com/apache/netbeans/pull/4096#issuecomment-1127774106
Thanks. Looks a good hotfix from my perspective! :+1: Let's discuss rest for NB15 (probably more than just adding to POM would be required though).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #4096: change default integration test goal action mapping to failsafe
Posted by GitBox <gi...@apache.org>.
ebarboni commented on PR #4096:
URL: https://github.com/apache/netbeans/pull/4096#issuecomment-1123374149
maybe we should go to pre-integration-test phase before calling failsafe:integration-test.
but the default action for unit test force plugin goal but not for IT test this is a bit inconsistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4096: change default integration test goal action mapping to failsafe
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4096:
URL: https://github.com/apache/netbeans/pull/4096#issuecomment-1123464738
> I'm not sure whether I really want to run integrationtests by default
@matthiasblaesing yes, please take a look back at #3470 as well as the report at #4089 This is about the ability to run / debug single test files or methods. This UI worked (kind of?!) in NB13 but not without additional configuration in NB14.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4096: change default integration test goal action mapping to failsafe
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4096:
URL: https://github.com/apache/netbeans/pull/4096#issuecomment-1122599327
Does this do a full build? I expect an integration test to have the final deployment artifact available. My use-case are dropwizard applications, where I need to test the case when the final fat jar is build (basicly after package, when integration test is regularly run). I'll try to remember to check tomorrow whether or not integration tests are run in my setup. For me the drawback is, that unittests are generally fast, my integration tests run in the range of a 15 minutes, so I'm not sure whether I really want to run integrationtests by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #4096: change default integration test goal action mapping to failsafe
Posted by GitBox <gi...@apache.org>.
ebarboni commented on PR #4096:
URL: https://github.com/apache/netbeans/pull/4096#issuecomment-1126687502
@matthiasblaesing did you had time to test on your system to see if it's break your workflow ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4096: change default integration test goal action mapping to failsafe
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4096:
URL: https://github.com/apache/netbeans/pull/4096#issuecomment-1126819613
@neilcsmith-net I would argue, that the current "run single test" action is broken as is and needs to be updated to call into `test`. Could we please stop to pretend, that the IDE can lift the requirements, that developers have to understand their job and read the f*** documentation?
Running a single integration test works as long as you did a baseline setup of the environment. If you can't do that, your integration test is already broken and thus useless. Your suggestion breaks working test while only giving toy tests the benefit to pretend to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4096: change default integration test goal action mapping to failsafe
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4096:
URL: https://github.com/apache/netbeans/pull/4096#issuecomment-1126891768
> a clean checkout fails now, as core goals are skipped (in my case package). Integration tests are run after package
@matthiasblaesing yes, one of the questions Eric and I have both raised is what goal(s) needs to run first, presumably `package` for this to work?
> I would argue, that the current "run single test" action is broken as is and needs to be updated to call into test ... Your suggestion breaks working test while only giving toy tests the benefit to pretend to work.
For the record, I agree with you here that _if feasible_ we should just call `test`, and in fact map all actions to Maven goals rather than plugins. That would depend on improving default POM and looking at the properties passed in to make this work though.
Also for the record, this isn't _my_ suggestion, but the action mappings should at least work in a consistent way (and this one could be made to function correctly).
As NB13 and NB14 are both broken here in different ways, it's not so much of a regression. IMO up to @ebarboni whether to update this PR with working pre-goals or not merge. Anything wider should be left for discussion in NB15.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists