You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/08/16 05:06:04 UTC

[GitHub] [apisix-dashboard] qsliu2017 opened a new pull request #2072: ci: optimize github actions

qsliu2017 opened a new pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072


   **Why submit this pull request?**
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [x] Improve performance
   - [ ] Backport patches
   
   **What changes will this PR take into?**
   
   1. modify on.[event].<paths|paths-ignore>.
   2. using paths-filter action to filter changed files' type.
   3. cache downloads and dependences.
   4. using buildx as docker build tool and cache docker layers.
   5. set up yarn cache of actions/setup-node
   
   **Related issues**
   
   fix/resolve #658 
   
   **Checklist:**
   
   - [x] Did you explain what problem does this PR solve? Or what new features have been added?
   - [ ] Have you added corresponding test cases?
   - [ ] Have you modified the corresponding document?
   - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

liuxiran edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-903397888


   it is strange that build rpm ci pending, do we have any idea to trigger it?
   
   Request help @nic-chen @Yiyiyimu @juzhiyuan , thanks a lot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] qsliu2017 commented on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

qsliu2017 commented on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-907766556


   @Yiyiyimu I add a new commit, but it doesn't work..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] qsliu2017 commented on a change in pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

qsliu2017 commented on a change in pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#discussion_r690869840



##########
File path: .github/workflows/go-lint.yml
##########
@@ -3,37 +3,72 @@ on:
   push:
     branches:
       - master
-    paths-ignore:
-      - 'docs/**'
-      - 'web/**'
+    paths:
+      - 'api/**'
   pull_request:
     branches:
       - master
-    paths-ignore:
-      - 'docs/**'
-      - 'web/**'
+    paths:
+      - 'api/**'
 
 jobs:
+  go-filter:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodule: true
+
+      - uses: ./.github/actions/paths-filter
+        id: changes
+        with:
+          filters: |
+            go:
+              - '**.go'
+          working-directory: 'api'
+          list-files: shell
+    outputs:
+      matches: ${{ steps.changes.outputs.go }}
+      files: ${{ steps.changes.outputs.go_files }}
+
   golangci:
     runs-on: ubuntu-latest
+    needs: go-filter
+    if: needs.go-filter.outputs.matches == 'true'
     steps:
       - uses: actions/checkout@v2
 
-      - name: run lint
-        run: make go-lint
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v2
+        with:
+          version: latest
+          working-directory: api
+          args: --tests=false
+          only-new-issues: true
 
   gofmt:
     runs-on: ubuntu-latest
+    needs: go-filter
+    if: needs.go-filter.outputs.matches == 'true'
     steps:
       - uses: actions/checkout@v2
       - name: setup go
         uses: actions/setup-go@v1
         with:
           go-version: '1.13'
+
+      - uses: actions/cache@v2
+        with:
+          path: |
+            ~/.cache/go-build
+            ~/go/pkg/mod
+          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
+          restore-keys: |
+            ${{ runner.os }}-go-

Review comment:
       This stage caches go mod and build to speed up go, see https://github.com/actions/cache/blob/main/examples.md#go---modules

##########
File path: .github/workflows/release-test.yml
##########
@@ -5,12 +5,32 @@ on:
     branches:
       - master
     paths-ignore:
+      - '.github/**'
+      - '.git/**'
+      - '.gitattributes'
+      - '.idea/**'
+      - '.vscode/**'
+      - '.gitignore'
+      - '.DS_Store'
       - 'docs/**'
+      - 'release/**'

Review comment:
       You're right. I just copy the exclude paths in makefile https://github.com/apache/apisix-dashboard/blob/28bca96908dabe4af48b06da8f2aeedbbafbe37c/Makefile#L113-L123

##########
File path: .github/workflows/auto-build-rpm.yml
##########
@@ -29,6 +29,19 @@ jobs:
       - name: Check out code
         uses: actions/checkout@v2
 
+      - uses: docker/setup-buildx-action@v1
+        with:
+          install: true
+
+      - run: docker login

Review comment:
       there exist credentials in the actions environment, see this step's result in https://github.com/apache/apisix-dashboard/pull/2072/checks?check_run_id=3354174287.
   I add this step to solve requests denied to access docker images, but it doesn't work. Maybe this PR has no authority to access private docker images?

##########
File path: .github/workflows/auto-build-rpm.yml
##########
@@ -29,6 +29,19 @@ jobs:
       - name: Check out code
         uses: actions/checkout@v2
 
+      - uses: docker/setup-buildx-action@v1
+        with:
+          install: true
+
+      - run: docker login

Review comment:
       @nic-chen Ok, I've removed it. But why docker request is denied?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] qsliu2017 commented on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

qsliu2017 commented on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-902557900


   > Docker `Buildx` with `docker-container` driver can't not access `docker images`. To fix it, we must modify Makefile in https://github.com/api7/apisix-build-tools.
   
   Yes!! I modify this makefile in my fork repo, that actually works! see https://github.com/qsliu2017/apisix-dashboard/runs/3380294505
   
   So I should make a PR to api7/apisix-build-tools first..


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] qsliu2017 commented on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

qsliu2017 commented on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-901735638


   > It's nice to cache docker layers. Do you know how much time could we save with this
   
   @Yiyiyimu since CI is not completed for this PR, I can't tell exactly.
   
   but I think rebuilding docker every workflow is the main reason for slow CI. see 
   
   ![](https://user-images.githubusercontent.com/57934883/130039364-a787673d-8d98-472d-b6d4-ea40b28329d6.png)
   
   ![](https://user-images.githubusercontent.com/57934883/130039425-c44595fc-55c3-4ee4-bdf7-1324d6204d6c.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   👷 Deploy Preview for *apisix-dashboard* processing.
   
   
   🔨 Explore the source changes: 68913abdf5c513ff08e66f53981ba83884edc5c1
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/611c92947b49b90007a311fa](https://app.netlify.com/sites/apisix-dashboard/deploys/611c92947b49b90007a311fa?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

starsz commented on a change in pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#discussion_r690833475



##########
File path: .github/workflows/auto-build-rpm.yml
##########
@@ -29,6 +29,19 @@ jobs:
       - name: Check out code
         uses: actions/checkout@v2
 
+      - uses: docker/setup-buildx-action@v1
+        with:
+          install: true
+
+      - run: docker login

Review comment:
       It seems that we don't provide the username and password when docker login?

##########
File path: .github/workflows/go-lint.yml
##########
@@ -3,37 +3,72 @@ on:
   push:
     branches:
       - master
-    paths-ignore:
-      - 'docs/**'
-      - 'web/**'
+    paths:
+      - 'api/**'
   pull_request:
     branches:
       - master
-    paths-ignore:
-      - 'docs/**'
-      - 'web/**'
+    paths:
+      - 'api/**'
 
 jobs:
+  go-filter:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodule: true
+
+      - uses: ./.github/actions/paths-filter
+        id: changes
+        with:
+          filters: |
+            go:
+              - '**.go'
+          working-directory: 'api'
+          list-files: shell
+    outputs:
+      matches: ${{ steps.changes.outputs.go }}
+      files: ${{ steps.changes.outputs.go_files }}
+
   golangci:
     runs-on: ubuntu-latest
+    needs: go-filter
+    if: needs.go-filter.outputs.matches == 'true'
     steps:
       - uses: actions/checkout@v2
 
-      - name: run lint
-        run: make go-lint
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v2
+        with:
+          version: latest
+          working-directory: api
+          args: --tests=false
+          only-new-issues: true
 
   gofmt:
     runs-on: ubuntu-latest
+    needs: go-filter
+    if: needs.go-filter.outputs.matches == 'true'
     steps:
       - uses: actions/checkout@v2
       - name: setup go
         uses: actions/setup-go@v1
         with:
           go-version: '1.13'
+
+      - uses: actions/cache@v2
+        with:
+          path: |
+            ~/.cache/go-build
+            ~/go/pkg/mod
+          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
+          restore-keys: |
+            ${{ runner.os }}-go-

Review comment:
       Just want to know what's the use of this stage?

##########
File path: .github/workflows/go-lint.yml
##########
@@ -3,37 +3,72 @@ on:
   push:
     branches:
       - master
-    paths-ignore:
-      - 'docs/**'
-      - 'web/**'
+    paths:
+      - 'api/**'
   pull_request:
     branches:
       - master
-    paths-ignore:
-      - 'docs/**'
-      - 'web/**'
+    paths:
+      - 'api/**'
 
 jobs:
+  go-filter:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodule: true
+
+      - uses: ./.github/actions/paths-filter
+        id: changes
+        with:
+          filters: |
+            go:
+              - '**.go'
+          working-directory: 'api'
+          list-files: shell
+    outputs:
+      matches: ${{ steps.changes.outputs.go }}
+      files: ${{ steps.changes.outputs.go_files }}
+
   golangci:
     runs-on: ubuntu-latest
+    needs: go-filter
+    if: needs.go-filter.outputs.matches == 'true'
     steps:
       - uses: actions/checkout@v2
 
-      - name: run lint
-        run: make go-lint
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v2
+        with:
+          version: latest
+          working-directory: api
+          args: --tests=false
+          only-new-issues: true
 
   gofmt:
     runs-on: ubuntu-latest
+    needs: go-filter
+    if: needs.go-filter.outputs.matches == 'true'
     steps:
       - uses: actions/checkout@v2
       - name: setup go
         uses: actions/setup-go@v1
         with:
           go-version: '1.13'
+
+      - uses: actions/cache@v2
+        with:
+          path: |
+            ~/.cache/go-build
+            ~/go/pkg/mod
+          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
+          restore-keys: |
+            ${{ runner.os }}-go-

Review comment:
       Pretty good !




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   👷 Deploy Preview for *apisix-dashboard* processing.
   
   
   🔨 Explore the source changes: 2c57f053149486fa025b85aa2c70417b1966aaf6
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/612cd615ea12c1000743da3d](https://app.netlify.com/sites/apisix-dashboard/deploys/612cd615ea12c1000743da3d?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899227133


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2072](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c11b714) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/28bca96908dabe4af48b06da8f2aeedbbafbe37c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (28bca96) will **decrease** coverage by `2.62%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head c11b714 differs from pull request most recent head fe20933. Consider uploading reports for the commit fe20933 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2072      +/-   ##
   ==========================================
   - Coverage   68.80%   66.18%   -2.63%     
   ==========================================
     Files         181      121      -60     
     Lines        7005     3226    -3779     
     Branches      787      787              
   ==========================================
   - Hits         4820     2135    -2685     
   + Misses       1901     1091     -810     
   + Partials      284        0     -284     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `66.18% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [api/cmd/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC92ZXJzaW9uLmdv) | | |
   | [.../internal/handler/authentication/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRpb24uZ28=) | | |
   | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | | |
   | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | | |
   | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | | |
   | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | | |
   | [api/internal/core/migrate/dataset.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9kYXRhc2V0Lmdv) | | |
   | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | | |
   | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | | |
   | [api/internal/handler/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbWlncmF0ZS9taWdyYXRlLmdv) | | |
   | ... and [50 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [28bca96...fe20933](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] qsliu2017 commented on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

qsliu2017 commented on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-902474366


   Shall I remove the part of optimizing docker, merge the rest first, and then finish the docker part in another PR? @nic-chen 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] qsliu2017 commented on a change in pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

qsliu2017 commented on a change in pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#discussion_r690869840



##########
File path: .github/workflows/go-lint.yml
##########
@@ -3,37 +3,72 @@ on:
   push:
     branches:
       - master
-    paths-ignore:
-      - 'docs/**'
-      - 'web/**'
+    paths:
+      - 'api/**'
   pull_request:
     branches:
       - master
-    paths-ignore:
-      - 'docs/**'
-      - 'web/**'
+    paths:
+      - 'api/**'
 
 jobs:
+  go-filter:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodule: true
+
+      - uses: ./.github/actions/paths-filter
+        id: changes
+        with:
+          filters: |
+            go:
+              - '**.go'
+          working-directory: 'api'
+          list-files: shell
+    outputs:
+      matches: ${{ steps.changes.outputs.go }}
+      files: ${{ steps.changes.outputs.go_files }}
+
   golangci:
     runs-on: ubuntu-latest
+    needs: go-filter
+    if: needs.go-filter.outputs.matches == 'true'
     steps:
       - uses: actions/checkout@v2
 
-      - name: run lint
-        run: make go-lint
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v2
+        with:
+          version: latest
+          working-directory: api
+          args: --tests=false
+          only-new-issues: true
 
   gofmt:
     runs-on: ubuntu-latest
+    needs: go-filter
+    if: needs.go-filter.outputs.matches == 'true'
     steps:
       - uses: actions/checkout@v2
       - name: setup go
         uses: actions/setup-go@v1
         with:
           go-version: '1.13'
+
+      - uses: actions/cache@v2
+        with:
+          path: |
+            ~/.cache/go-build
+            ~/go/pkg/mod
+          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
+          restore-keys: |
+            ${{ runner.os }}-go-

Review comment:
       This stage caches go mod and build to speed up go, see https://github.com/actions/cache/blob/main/examples.md#go---modules




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   ✔️ Deploy Preview for *apisix-dashboard* ready!
   
   
   🔨 Explore the source changes: 43ade57200b5e0771cd1f5c052ee9a708454a469
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6122fe0ec3f34400087c131a](https://app.netlify.com/sites/apisix-dashboard/deploys/6122fe0ec3f34400087c131a?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-2072--apisix-dashboard.netlify.app](https://deploy-preview-2072--apisix-dashboard.netlify.app?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

juzhiyuan commented on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-903602448


   😳😳


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] qsliu2017 commented on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

qsliu2017 commented on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-908330125


    > I don't think we could change the requirement of that action, since we need it to be required.
   > 
   > Maybe you could try to revert the change on https://github.com/qsliu2017/apisix-dashboard/blob/optimize-ci/.github/workflows/test-frontend-multiple-node-build.yml, to see if it works
   
   Ohh, that actually works! But I still wonder if we really need to trigger this action when `web/**` not change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

liuxiran commented on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-903397888


   it is strange that build rmp ci pending, do we have any idea to trigger it?
   
   Request help @nic-chen @Yiyiyimu @juzhiyuan , thanks a lot


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899227133


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2072](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bba2de0) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/fb789638b30019e10f9d0359bebee01de8bae125?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb78963) will **decrease** coverage by `2.29%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2072      +/-   ##
   ==========================================
   - Coverage   68.87%   66.57%   -2.30%     
   ==========================================
     Files         181      121      -60     
     Lines        7010     3231    -3779     
     Branches      787      787              
   ==========================================
   - Hits         4828     2151    -2677     
   + Misses       1898     1080     -818     
   + Partials      284        0     -284     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `66.57% <ø> (-0.07%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `70.49% <0.00%> (-3.28%)` | :arrow_down: |
   | [api/internal/core/migrate/conflict.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9jb25mbGljdC5nbw==) | | |
   | [api/internal/filter/logging.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9sb2dnaW5nLmdv) | | |
   | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | | |
   | [api/internal/core/server/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3N0b3JlLmdv) | | |
   | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | | |
   | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | | |
   | [api/cmd/root.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9yb290Lmdv) | | |
   | [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | | |
   | [api/internal/handler/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbWlncmF0ZS9taWdyYXRlLmdv) | | |
   | ... and [51 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fb78963...bba2de0](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Yiyiyimu commented on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

Yiyiyimu commented on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-908817176


   > Ohh, that actually works! But I still wonder if we really need to trigger this action when web/** not change
   
   @qsliu2017 good to know that! And I believe the same with you. Maybe you could tweak more about it in another PR if you got time!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] qsliu2017 commented on a change in pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

qsliu2017 commented on a change in pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#discussion_r691137729



##########
File path: .github/workflows/auto-build-rpm.yml
##########
@@ -29,6 +29,19 @@ jobs:
       - name: Check out code
         uses: actions/checkout@v2
 
+      - uses: docker/setup-buildx-action@v1
+        with:
+          install: true
+
+      - run: docker login

Review comment:
       @nic-chen Ok, I've removed it. But why docker request is denied?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] qsliu2017 commented on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

qsliu2017 commented on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-907771479


   @Yiyiyimu I even try to open a new PR, but the same problem.
   
   I find a solution https://github.community/t/github-actions-pull-requests-always-include-some-outdated-checks/16157, can you set build to not required?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   👷 Deploy Preview for *apisix-dashboard* processing.
   
   
   🔨 Explore the source changes: 60df47cb8b9c51b6d7774325957fefabbd6f9a2b
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/612097e61222330007278e30](https://app.netlify.com/sites/apisix-dashboard/deploys/612097e61222330007278e30?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Yiyiyimu commented on a change in pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

Yiyiyimu commented on a change in pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#discussion_r693364551



##########
File path: .github/workflows/release-test.yml
##########
@@ -5,12 +5,30 @@ on:
     branches:
       - master
     paths-ignore:
+      - '.github/**'
+      - '.git/**'
+      - '.gitattributes'
+      - '.idea/**'
+      - '.vscode/**'

Review comment:
       Maybe adding `.vscode` to `.gitignore` would be better, since it's the same type as `.idea`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   👷 Deploy Preview for *apisix-dashboard* processing.
   
   
   🔨 Explore the source changes: ce6bb1d7fa5c25c8040136191f35d90a2a7322bf
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/611ce78601d3ea0007ad56b2](https://app.netlify.com/sites/apisix-dashboard/deploys/611ce78601d3ea0007ad56b2?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   👷 Deploy Preview for *apisix-dashboard* processing.
   
   
   🔨 Explore the source changes: d7c554738c72abef97a8c5dcfe52224ba264981c
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/611e1dcd6aa1ad0008fddada](https://app.netlify.com/sites/apisix-dashboard/deploys/611e1dcd6aa1ad0008fddada?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Yiyiyimu commented on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

Yiyiyimu commented on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-907706412


   @qsliu2017 do you mind adding a new commit (say merge master)? It seems there is something wrong with github actions, as you see three workflows got stuck and I failed to trigger it on my side. Hopefully a new commit could fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899227133


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2072](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (022b48a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9b18c35d3c61ccfb8c48bd458568c86ac902491e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9b18c35) will **increase** coverage by `0.81%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head 022b48a differs from pull request most recent head 43ade57. Consider uploading reports for the commit 43ade57 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2072      +/-   ##
   ==========================================
   + Coverage   65.82%   66.63%   +0.81%     
   ==========================================
     Files         181      121      -60     
     Lines        7010     3231    -3779     
     Branches      787      787              
   ==========================================
   - Hits         4614     2153    -2461     
   + Misses       2112     1078    -1034     
   + Partials      284        0     -284     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `66.63% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | | |
   | [api/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL21haW4uZ28=) | | |
   | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | | |
   | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | | |
   | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | | |
   | [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | | |
   | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | | |
   | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | | |
   | [api/cmd/install.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9pbnN0YWxsLmdv) | | |
   | [api/cmd/status.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zdGF0dXMuZ28=) | | |
   | ... and [50 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9b18c35...43ade57](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899227133


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2072](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d3e705) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/28bca96908dabe4af48b06da8f2aeedbbafbe37c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (28bca96) will **decrease** coverage by `2.23%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2072      +/-   ##
   ==========================================
   - Coverage   68.80%   66.57%   -2.24%     
   ==========================================
     Files         181      121      -60     
     Lines        7005     3231    -3774     
     Branches      787      787              
   ==========================================
   - Hits         4820     2151    -2669     
   + Misses       1901     1080     -821     
   + Partials      284        0     -284     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `66.57% <ø> (+0.39%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `70.49% <0.00%> (-3.28%)` | :arrow_down: |
   | [web/src/components/Plugin/UI/proxy-mirror.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wcm94eS1taXJyb3IudHN4) | `100.00% <0.00%> (ø)` | |
   | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | | |
   | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | | |
   | [api/cmd/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zZXJ2aWNlLmdv) | | |
   | [api/internal/core/server/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3N0b3JlLmdv) | | |
   | [.../internal/handler/authentication/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRpb24uZ28=) | | |
   | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | | |
   | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | | |
   | [api/cmd/install.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9pbnN0YWxsLmdv) | | |
   | ... and [56 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [28bca96...3d3e705](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899227133


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2072](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fab95eb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8f47e3405d2a7dfbdd8999350b1b29d4c6dc7fed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f47e34) will **decrease** coverage by `2.64%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head fab95eb differs from pull request most recent head ce6bb1d. Consider uploading reports for the commit ce6bb1d to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2072      +/-   ##
   ==========================================
   - Coverage   68.82%   66.18%   -2.65%     
   ==========================================
     Files         181      121      -60     
     Lines        7005     3226    -3779     
     Branches      787      787              
   ==========================================
   - Hits         4821     2135    -2686     
   + Misses       1901     1091     -810     
   + Partials      283        0     -283     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `66.18% <ø> (+0.06%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | | |
   | [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | | |
   | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | | |
   | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | | |
   | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | | |
   | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | | |
   | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | | |
   | [api/internal/core/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9taWdyYXRlLmdv) | | |
   | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | | |
   | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | | |
   | ... and [50 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8f47e34...ce6bb1d](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

nic-chen commented on a change in pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#discussion_r690956829



##########
File path: .github/workflows/auto-build-rpm.yml
##########
@@ -29,6 +29,19 @@ jobs:
       - name: Check out code
         uses: actions/checkout@v2
 
+      - uses: docker/setup-buildx-action@v1
+        with:
+          install: true
+
+      - run: docker login

Review comment:
       @qsliu2017  we don't need to login here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

nic-chen commented on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-902769967


   > Shall I remove the part of optimizing docker, merge the rest first, and then finish the docker part in another PR? @nic-chen 
   
   yes, we could merge the rest first. @qsliu2017 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   ✔️ Deploy Preview for *apisix-dashboard* ready!
   
   
   🔨 Explore the source changes: bba2de0fb3da360d8b7c61ce91fb909d73ba3425
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/612b3b48e4a33d00078b1c13](https://app.netlify.com/sites/apisix-dashboard/deploys/612b3b48e4a33d00078b1c13?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-2072--apisix-dashboard.netlify.app](https://deploy-preview-2072--apisix-dashboard.netlify.app?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   ✔️ Deploy Preview for *apisix-dashboard* ready!
   
   
   🔨 Explore the source changes: 6bea0f8317310d1a3ea36102e0520cee7b19c3ab
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/611f320a6ac5de0008c65df3](https://app.netlify.com/sites/apisix-dashboard/deploys/611f320a6ac5de0008c65df3?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-2072--apisix-dashboard.netlify.app](https://deploy-preview-2072--apisix-dashboard.netlify.app?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

liuxiran commented on a change in pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#discussion_r690656261



##########
File path: .github/workflows/release-test.yml
##########
@@ -5,12 +5,32 @@ on:
     branches:
       - master
     paths-ignore:
+      - '.github/**'
+      - '.git/**'
+      - '.gitattributes'
+      - '.idea/**'
+      - '.vscode/**'
+      - '.gitignore'
+      - '.DS_Store'
       - 'docs/**'
+      - 'release/**'

Review comment:
       we do  not have `release/**` dir, may I ask why we need to ignore it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Yiyiyimu commented on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

Yiyiyimu commented on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-908817176


   > Ohh, that actually works! But I still wonder if we really need to trigger this action when web/** not change
   
   @qsliu2017 good to know that! And I believe the same with you. Maybe you could tweak more about it in another PR if you got time!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] qsliu2017 commented on a change in pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

qsliu2017 commented on a change in pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#discussion_r690896077



##########
File path: .github/workflows/release-test.yml
##########
@@ -5,12 +5,32 @@ on:
     branches:
       - master
     paths-ignore:
+      - '.github/**'
+      - '.git/**'
+      - '.gitattributes'
+      - '.idea/**'
+      - '.vscode/**'
+      - '.gitignore'
+      - '.DS_Store'
       - 'docs/**'
+      - 'release/**'

Review comment:
       You're right. I just copy the exclude paths in makefile https://github.com/apache/apisix-dashboard/blob/28bca96908dabe4af48b06da8f2aeedbbafbe37c/Makefile#L113-L123




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   👷 Deploy Preview for *apisix-dashboard* processing.
   
   
   🔨 Explore the source changes: 43ade57200b5e0771cd1f5c052ee9a708454a469
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6122fe0ec3f34400087c131a](https://app.netlify.com/sites/apisix-dashboard/deploys/6122fe0ec3f34400087c131a?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

juzhiyuan merged pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] qsliu2017 commented on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

qsliu2017 commented on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-903072805


   @nic-chen OK! this PR is ready to be merged, please check!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

starsz commented on a change in pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#discussion_r690833475



##########
File path: .github/workflows/auto-build-rpm.yml
##########
@@ -29,6 +29,19 @@ jobs:
       - name: Check out code
         uses: actions/checkout@v2
 
+      - uses: docker/setup-buildx-action@v1
+        with:
+          install: true
+
+      - run: docker login

Review comment:
       It seems that we don't provide the username and password when docker login?

##########
File path: .github/workflows/go-lint.yml
##########
@@ -3,37 +3,72 @@ on:
   push:
     branches:
       - master
-    paths-ignore:
-      - 'docs/**'
-      - 'web/**'
+    paths:
+      - 'api/**'
   pull_request:
     branches:
       - master
-    paths-ignore:
-      - 'docs/**'
-      - 'web/**'
+    paths:
+      - 'api/**'
 
 jobs:
+  go-filter:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodule: true
+
+      - uses: ./.github/actions/paths-filter
+        id: changes
+        with:
+          filters: |
+            go:
+              - '**.go'
+          working-directory: 'api'
+          list-files: shell
+    outputs:
+      matches: ${{ steps.changes.outputs.go }}
+      files: ${{ steps.changes.outputs.go_files }}
+
   golangci:
     runs-on: ubuntu-latest
+    needs: go-filter
+    if: needs.go-filter.outputs.matches == 'true'
     steps:
       - uses: actions/checkout@v2
 
-      - name: run lint
-        run: make go-lint
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v2
+        with:
+          version: latest
+          working-directory: api
+          args: --tests=false
+          only-new-issues: true
 
   gofmt:
     runs-on: ubuntu-latest
+    needs: go-filter
+    if: needs.go-filter.outputs.matches == 'true'
     steps:
       - uses: actions/checkout@v2
       - name: setup go
         uses: actions/setup-go@v1
         with:
           go-version: '1.13'
+
+      - uses: actions/cache@v2
+        with:
+          path: |
+            ~/.cache/go-build
+            ~/go/pkg/mod
+          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
+          restore-keys: |
+            ${{ runner.os }}-go-

Review comment:
       Just want to know what's the use of this stage?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

starsz commented on a change in pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#discussion_r691406200



##########
File path: .github/workflows/go-lint.yml
##########
@@ -3,37 +3,72 @@ on:
   push:
     branches:
       - master
-    paths-ignore:
-      - 'docs/**'
-      - 'web/**'
+    paths:
+      - 'api/**'
   pull_request:
     branches:
       - master
-    paths-ignore:
-      - 'docs/**'
-      - 'web/**'
+    paths:
+      - 'api/**'
 
 jobs:
+  go-filter:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodule: true
+
+      - uses: ./.github/actions/paths-filter
+        id: changes
+        with:
+          filters: |
+            go:
+              - '**.go'
+          working-directory: 'api'
+          list-files: shell
+    outputs:
+      matches: ${{ steps.changes.outputs.go }}
+      files: ${{ steps.changes.outputs.go_files }}
+
   golangci:
     runs-on: ubuntu-latest
+    needs: go-filter
+    if: needs.go-filter.outputs.matches == 'true'
     steps:
       - uses: actions/checkout@v2
 
-      - name: run lint
-        run: make go-lint
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v2
+        with:
+          version: latest
+          working-directory: api
+          args: --tests=false
+          only-new-issues: true
 
   gofmt:
     runs-on: ubuntu-latest
+    needs: go-filter
+    if: needs.go-filter.outputs.matches == 'true'
     steps:
       - uses: actions/checkout@v2
       - name: setup go
         uses: actions/setup-go@v1
         with:
           go-version: '1.13'
+
+      - uses: actions/cache@v2
+        with:
+          path: |
+            ~/.cache/go-build
+            ~/go/pkg/mod
+          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
+          restore-keys: |
+            ${{ runner.os }}-go-

Review comment:
       Pretty good !




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   ✔️ Deploy Preview for *apisix-dashboard* ready!
   
   
   🔨 Explore the source changes: fe20933687cc61a441f3ce8b65dedb3e7e376b31
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/611f2b2441c02600098a4976](https://app.netlify.com/sites/apisix-dashboard/deploys/611f2b2441c02600098a4976?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-2072--apisix-dashboard.netlify.app](https://deploy-preview-2072--apisix-dashboard.netlify.app?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] commented on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   👷 Deploy Preview for *apisix-dashboard* processing.
   
   
   🔨 Explore the source changes: fcc21b757b171232c051ae9ec9b1972e8a06e82d
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6119f23513d89c00094da7ac](https://app.netlify.com/sites/apisix-dashboard/deploys/6119f23513d89c00094da7ac?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   👷 Deploy Preview for *apisix-dashboard* processing.
   
   
   🔨 Explore the source changes: fe20933687cc61a441f3ce8b65dedb3e7e376b31
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/611f2b2441c02600098a4976](https://app.netlify.com/sites/apisix-dashboard/deploys/611f2b2441c02600098a4976?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Yiyiyimu commented on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

Yiyiyimu commented on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-907892403


   > @Yiyiyimu I even try to open a new PR, but the same problem.
   > 
   > I find a solution [github.community/t/github-actions-pull-requests-always-include-some-outdated-checks/16157](https://github.community/t/github-actions-pull-requests-always-include-some-outdated-checks/16157), can you set build to not required?
   
   I don't think we could change the requirement of that action, since we need it to be required.
   
   Maybe you could try to revert the change on https://github.com/qsliu2017/apisix-dashboard/blob/optimize-ci/.github/workflows/test-frontend-multiple-node-build.yml, to see if it works
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] qsliu2017 commented on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

qsliu2017 commented on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-903070263


   @Yiyiyimu In the latest commit, docker build's time can decrease to just 1 min!! Because most steps are cached
   
   ![](https://user-images.githubusercontent.com/57934883/130313271-8463a671-9432-469a-821d-f0bd751a024c.png)
   ![](https://user-images.githubusercontent.com/57934883/130313277-48c52e36-1881-4f54-8739-a279d4cb67b4.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] qsliu2017 commented on a change in pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

qsliu2017 commented on a change in pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#discussion_r692627465



##########
File path: .github/workflows/deploy-with-docker.yml
##########
@@ -25,6 +25,17 @@ jobs:
         with:
           submodules: recursive
 
+      - uses: docker/setup-buildx-action@v1

Review comment:
       @nic-chen thank you!! I find that buildx will not load built images to `docker images`. I'm trying to fix it!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

nic-chen commented on a change in pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#discussion_r690956829



##########
File path: .github/workflows/auto-build-rpm.yml
##########
@@ -29,6 +29,19 @@ jobs:
       - name: Check out code
         uses: actions/checkout@v2
 
+      - uses: docker/setup-buildx-action@v1
+        with:
+          install: true
+
+      - run: docker login

Review comment:
       @qsliu2017  we don't need to login here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899227133


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2072](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fab95eb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8f47e3405d2a7dfbdd8999350b1b29d4c6dc7fed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f47e34) will **decrease** coverage by `2.64%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head fab95eb differs from pull request most recent head ce6bb1d. Consider uploading reports for the commit ce6bb1d to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2072      +/-   ##
   ==========================================
   - Coverage   68.82%   66.18%   -2.65%     
   ==========================================
     Files         181      121      -60     
     Lines        7005     3226    -3779     
     Branches      787      787              
   ==========================================
   - Hits         4821     2135    -2686     
   + Misses       1901     1091     -810     
   + Partials      283        0     -283     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `66.18% <ø> (+0.06%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | | |
   | [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | | |
   | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | | |
   | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | | |
   | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | | |
   | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | | |
   | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | | |
   | [api/internal/core/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9taWdyYXRlLmdv) | | |
   | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | | |
   | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | | |
   | ... and [50 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8f47e34...ce6bb1d](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   ✔️ Deploy Preview for *apisix-dashboard* ready!
   
   
   🔨 Explore the source changes: 3d3e7057d7b20e14a58d76dcd883e0d2f44aefc4
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/61209d3f434a3c0008c8bd3b](https://app.netlify.com/sites/apisix-dashboard/deploys/61209d3f434a3c0008c8bd3b?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-2072--apisix-dashboard.netlify.app](https://deploy-preview-2072--apisix-dashboard.netlify.app?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] Yiyiyimu commented on a change in pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

Yiyiyimu commented on a change in pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#discussion_r691686848



##########
File path: .github/workflows/release-test.yml
##########
@@ -5,12 +5,30 @@ on:
     branches:
       - master
     paths-ignore:
+      - '.github/**'
+      - '.git/**'
+      - '.gitattributes'
+      - '.idea/**'
+      - '.vscode/**'

Review comment:
       I don't think we need to ignore `.idea` or `.vscode` here since `gitignore` has already done this for us




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   ✔️ Deploy Preview for *apisix-dashboard* ready!
   
   
   🔨 Explore the source changes: ce6bb1d7fa5c25c8040136191f35d90a2a7322bf
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/611ce78601d3ea0007ad56b2](https://app.netlify.com/sites/apisix-dashboard/deploys/611ce78601d3ea0007ad56b2?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-2072--apisix-dashboard.netlify.app](https://deploy-preview-2072--apisix-dashboard.netlify.app?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   ✔️ Deploy Preview for *apisix-dashboard* ready!
   
   
   🔨 Explore the source changes: d7c554738c72abef97a8c5dcfe52224ba264981c
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/611e1dcd6aa1ad0008fddada](https://app.netlify.com/sites/apisix-dashboard/deploys/611e1dcd6aa1ad0008fddada?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-2072--apisix-dashboard.netlify.app/](https://deploy-preview-2072--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899227133


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2072](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fb087da) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8f47e3405d2a7dfbdd8999350b1b29d4c6dc7fed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f47e34) will **decrease** coverage by `2.70%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head fb087da differs from pull request most recent head fcc21b7. Consider uploading reports for the commit fcc21b7 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2072      +/-   ##
   ==========================================
   - Coverage   68.82%   66.11%   -2.71%     
   ==========================================
     Files         181      121      -60     
     Lines        7005     3226    -3779     
     Branches      787      787              
   ==========================================
   - Hits         4821     2133    -2688     
   + Misses       1901     1093     -808     
   + Partials      283        0     -283     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `66.11% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [api/cmd/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9zZXJ2aWNlLmdv) | | |
   | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | | |
   | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | |
   | [api/internal/handler/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbWlncmF0ZS9taWdyYXRlLmdv) | | |
   | [api/internal/core/server/http.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL2h0dHAuZ28=) | | |
   | [api/cmd/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC92ZXJzaW9uLmdv) | | |
   | [api/internal/core/server/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3N0b3JlLmdv) | | |
   | [api/internal/filter/logging.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9sb2dnaW5nLmdv) | | |
   | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | | |
   | [api/internal/core/store/store\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVfbW9jay5nbw==) | | |
   | ... and [50 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8f47e34...fcc21b7](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] qsliu2017 commented on a change in pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

qsliu2017 commented on a change in pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#discussion_r691925963



##########
File path: .github/workflows/release-test.yml
##########
@@ -5,12 +5,30 @@ on:
     branches:
       - master
     paths-ignore:
+      - '.github/**'
+      - '.git/**'
+      - '.gitattributes'
+      - '.idea/**'
+      - '.vscode/**'

Review comment:
       @Yiyiyimu I've removed the paths that are already in `.gitignore`. `.vscode` is remained because it's not in it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   👷 Deploy Preview for *apisix-dashboard* processing.
   
   
   🔨 Explore the source changes: ca7776148911d162c16fe52c517599ade12a1adf
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/611f31ad57d4f80008d9c7e7](https://app.netlify.com/sites/apisix-dashboard/deploys/611f31ad57d4f80008d9c7e7?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] qsliu2017 commented on a change in pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

qsliu2017 commented on a change in pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#discussion_r690898813



##########
File path: .github/workflows/auto-build-rpm.yml
##########
@@ -29,6 +29,19 @@ jobs:
       - name: Check out code
         uses: actions/checkout@v2
 
+      - uses: docker/setup-buildx-action@v1
+        with:
+          install: true
+
+      - run: docker login

Review comment:
       there exist credentials in the actions environment, see this step's result in https://github.com/apache/apisix-dashboard/pull/2072/checks?check_run_id=3354174287.
   I add this step to solve requests denied to access docker images, but it doesn't work. Maybe this PR has no authority to access private docker images?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   ✔️ Deploy Preview for *apisix-dashboard* ready!
   
   
   🔨 Explore the source changes: 68913abdf5c513ff08e66f53981ba83884edc5c1
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/611c92947b49b90007a311fa](https://app.netlify.com/sites/apisix-dashboard/deploys/611c92947b49b90007a311fa?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-2072--apisix-dashboard.netlify.app](https://deploy-preview-2072--apisix-dashboard.netlify.app?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   👷 Deploy Preview for *apisix-dashboard* processing.
   
   
   🔨 Explore the source changes: 6ac1f82f68a336c48d06e4fc84cc5023ed453cfa
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/611f152c57d4f80008d7d9ef](https://app.netlify.com/sites/apisix-dashboard/deploys/611f152c57d4f80008d7d9ef?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

codecov-commenter edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899227133


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2072](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (88c50c9) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/28bca96908dabe4af48b06da8f2aeedbbafbe37c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (28bca96) will **decrease** coverage by `2.62%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2072      +/-   ##
   ==========================================
   - Coverage   68.80%   66.18%   -2.63%     
   ==========================================
     Files         181      121      -60     
     Lines        7005     3226    -3779     
     Branches      787      787              
   ==========================================
   - Hits         4820     2135    -2685     
   + Misses       1901     1091     -810     
   + Partials      284        0     -284     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | backend-e2e-test | `?` | |
   | backend-e2e-test-ginkgo | `?` | |
   | backend-unit-test | `?` | |
   | frontend-e2e-test | `66.18% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [api/cmd/remove.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9yZW1vdmUuZ28=) | | |
   | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | | |
   | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | | |
   | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | | |
   | [api/internal/core/migrate/conflict.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvbWlncmF0ZS9jb25mbGljdC5nbw==) | | |
   | [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | | |
   | [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | | |
   | [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | | |
   | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | | |
   | [api/internal/core/server/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc2VydmVyL3N0b3JlLmdv) | | |
   | ... and [50 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2072/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [28bca96...88c50c9](https://codecov.io/gh/apache/apisix-dashboard/pull/2072?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

juzhiyuan merged pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

liuxiran commented on a change in pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#discussion_r690656261



##########
File path: .github/workflows/release-test.yml
##########
@@ -5,12 +5,32 @@ on:
     branches:
       - master
     paths-ignore:
+      - '.github/**'
+      - '.git/**'
+      - '.gitattributes'
+      - '.idea/**'
+      - '.vscode/**'
+      - '.gitignore'
+      - '.DS_Store'
       - 'docs/**'
+      - 'release/**'

Review comment:
       we do  not have `release/**` dir, may I ask why we need to ignore it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   ✔️ Deploy Preview for *apisix-dashboard* ready!
   
   
   🔨 Explore the source changes: fcc21b757b171232c051ae9ec9b1972e8a06e82d
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6119f23513d89c00094da7ac](https://app.netlify.com/sites/apisix-dashboard/deploys/6119f23513d89c00094da7ac?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-2072--apisix-dashboard.netlify.app](https://deploy-preview-2072--apisix-dashboard.netlify.app?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

nic-chen commented on a change in pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#discussion_r692003120



##########
File path: .github/workflows/deploy-with-docker.yml
##########
@@ -25,6 +25,17 @@ jobs:
         with:
           submodules: recursive
 
+      - uses: docker/setup-buildx-action@v1

Review comment:
       It seems that the introduction of this part leads to the pull of the just-built `dashboard:ci` ?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   ✔️ Deploy Preview for *apisix-dashboard* ready!
   
   
   🔨 Explore the source changes: 2c57f053149486fa025b85aa2c70417b1966aaf6
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/612cd615ea12c1000743da3d](https://app.netlify.com/sites/apisix-dashboard/deploys/612cd615ea12c1000743da3d?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-2072--apisix-dashboard.netlify.app](https://deploy-preview-2072--apisix-dashboard.netlify.app?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   ✔️ Deploy Preview for *apisix-dashboard* ready!
   
   
   🔨 Explore the source changes: 88c50c9818bb057e6e33cf58c14d75eaced517a0
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/611f15fdd20fcf0008964b2f](https://app.netlify.com/sites/apisix-dashboard/deploys/611f15fdd20fcf0008964b2f?utm_source=github&utm_campaign=bot_dl)
   
   😎 Browse the preview: [https://deploy-preview-2072--apisix-dashboard.netlify.app](https://deploy-preview-2072--apisix-dashboard.netlify.app?utm_source=github&utm_campaign=bot_dp)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668


   👷 Deploy Preview for *apisix-dashboard* processing.
   
   
   🔨 Explore the source changes: bba2de0fb3da360d8b7c61ce91fb909d73ba3425
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/612b3b48e4a33d00078b1c13](https://app.netlify.com/sites/apisix-dashboard/deploys/612b3b48e4a33d00078b1c13?utm_source=github&utm_campaign=bot_dl)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] qsliu2017 commented on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

qsliu2017 commented on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-908330125


    > I don't think we could change the requirement of that action, since we need it to be required.
   > 
   > Maybe you could try to revert the change on https://github.com/qsliu2017/apisix-dashboard/blob/optimize-ci/.github/workflows/test-frontend-multiple-node-build.yml, to see if it works
   
   Ohh, that actually works! But I still wonder if we really need to trigger this action when `web/**` not change


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] qsliu2017 commented on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

qsliu2017 commented on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-902472574


   Docker `Buildx` with `docker-container` driver can't not access `docker images`. To fix it, we must modify Makefile in https://github.com/api7/apisix-build-tools.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2072: ci: optimize github actions

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #2072:
URL: https://github.com/apache/apisix-dashboard/pull/2072#issuecomment-899216668






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org