[GitHub] [pulsar] gaoran10 commented on a change in pull request #6422: [Issue 6283][tiered-storage] Offload policies per namespace

[GitBox <gi...@apache.org>]

gaoran10 commented on a change in pull request #6422: [Issue 6283][tiered-storage] Offload policies per namespace
URL: https://github.com/apache/pulsar/pull/6422#discussion_r389493985
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
 ##########
 @@ -2122,7 +2122,12 @@ protected void internalSetCompactionThreshold(long newThreshold) {
 
     protected long internalGetOffloadThreshold() {
         validateAdminAccessForTenant(namespaceName.getTenant());
-        return getNamespacePolicies(namespaceName).offload_threshold;
+        Policies policies = getNamespacePolicies(namespaceName);
+        if (policies.offload_policies == null) {
+            return policies.offload_threshold;
 
 Review comment:
   Can we delete ```offload_threshold ``` and ```offload_deletion_lag_ms``` in Policies.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services