You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/02 12:09:16 UTC

[GitHub] [flink] cuibo01 commented on a change in pull request #17332: [FLINK-24349]Support customized Calalogs via JDBC

cuibo01 commented on a change in pull request #17332:
URL: https://github.com/apache/flink/pull/17332#discussion_r720671425



##########
File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/JdbcDialect.java
##########
@@ -142,4 +143,16 @@
      */
     String getSelectFromStatement(
             String tableName, String[] selectFields, String[] conditionFields);
+
+    /** Create catalog instance. */
+    default AbstractJdbcCatalog createCatalog(
+            String catalogName,

Review comment:
       Yes, you are right. 
   But I dont understand why you have to refactor the code on this PR. This PR is designed to support custom calalogs :-)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org