You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by PSUdaemon <gi...@git.apache.org> on 2016/02/16 05:46:06 UTC
[GitHub] trafficserver pull request: TS-4211: Make freelist_new cleaner so ...
GitHub user PSUdaemon opened a pull request:
https://github.com/apache/trafficserver/pull/481
TS-4211: Make freelist_new cleaner so we can debug better.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PSUdaemon/trafficserver freelist_new_clean
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/481.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #481
----
commit d2ccc280a46728635bd7495cc140add63215b7ce
Author: Phil Sorber <so...@apache.org>
Date: 2016-02-14T05:54:26Z
TS-4211: Make freelist_new cleaner so we can debug better.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4211: Make freelist_new cleaner so ...
Posted by bgaff <gi...@git.apache.org>.
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/481#issuecomment-184524565
All good :+1: just set alignment = 0 on declaration and let the complier deal with it if it's always assigned later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4211: Make freelist_new cleaner so ...
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon closed the pull request at:
https://github.com/apache/trafficserver/pull/481
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4211: Make freelist_new cleaner so ...
Posted by bgaff <gi...@git.apache.org>.
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/481#discussion_r52969591
--- Diff: lib/ts/ink_queue.cc ---
@@ -200,19 +200,20 @@ freelist_new(InkFreeList *f)
if (TO_PTR(FREELIST_POINTER(item)) == NULL) {
uint32_t i;
void *newp = NULL;
- size_t alloc_size = 0;
+ size_t alloc_size = f->chunk_size * f->type_size;
+ size_t alignment;
--- End diff --
= 0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4211: Make freelist_new cleaner so ...
Posted by bgaff <gi...@git.apache.org>.
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/481#issuecomment-184527976
I just confirmed that this is correct, it will actually be hugepage aligned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4211: Make freelist_new cleaner so ...
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon commented on the pull request:
https://github.com/apache/trafficserver/pull/481#issuecomment-184719907
I addressed the comments above. At some point in the future I want to replace this with a page allocator for the freelists but that is going to be a bigger task.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4211: Make freelist_new cleaner so ...
Posted by PSUdaemon <gi...@git.apache.org>.
Github user PSUdaemon commented on the pull request:
https://github.com/apache/trafficserver/pull/481#issuecomment-186442215
Merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---