[jira] Commented: (DERBY-2019) IJ's describe command does not handle quotes very well

["John H. Embretsen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12493990 ] 

John H. Embretsen commented on DERBY-2019:
------------------------------------------

Thank you very much for the patch and documentation work, Bryan! I tried the patch, and it resolves all the odd cases reported in this Jira issue. I have not run any other tests with the patch, but I noticed that a number of both positive and negative test statements for the describe command were added to the tools/ij7.sql test script. Nicely done!

Also, now that the documentation will be improved, I can certainly accept the potentially slightly confusing error messages for
 - describe without a valid argument, e.g. 
     ij> describe *;
     ERROR 42X01: Syntax error: Encountered "describe" at line 1, column 1.
 - using the wildcard '*' in a schema with no tables/views
     ij> describe '*';
     IJ ERROR: No table exists with the name null
 
I'd say go ahead and commit these changes, unless there are further comments.

> IJ's describe command does not handle quotes very well
> ------------------------------------------------------
>
>                 Key: DERBY-2019
>                 URL: https://issues.apache.org/jira/browse/DERBY-2019
>             Project: Derby
>          Issue Type: Bug
>          Components: Tools
>    Affects Versions: 10.2.1.6, 10.3.0.0
>            Reporter: John H. Embretsen
>         Assigned To: Bryan Pendleton
>            Priority: Minor
>         Attachments: describe_enhancement.diff, docs.diff, rtoolsijcomrefdescribe.html
>
>
> In IJ, the describe <table | view> command does not handle quotes very well. Current behavior is:
> a) Double quotes:
> IJ does not recognize describe command when encountering double quotes.
>     ij> create table "CamelCaseTable" (col1_in_cct int);
>     0 rows inserted/updated/deleted
>     ij> describe "CamelCaseTable";
>     ERROR 42X01: Syntax error: Encountered "describe" at line 1, column 1.
> I'm assuming that it should be possible to execute the describe command on case-sensitive table names.
> b) Single quotes:
> IJ describes all tables in current schema when encountering two single quotes after the describe command.
>     ij> create table table1 (col1_table1 int);
>     0 rows inserted/updated/deleted
>     ij> create table table2 (col1_table2 int);
>     0 rows inserted/updated/deleted
>     ij> describe '';
>     COLUMN_NAME         |TYPE_NAME|DEC&|NUM&|COLUM&|COLUMN_DEF|CHAR_OCTE&|IS_NULL&
>     ------------------------------------------------------------------------------
>     COL1_TABLE1         |INTEGER  |0   |10  |10    |NULL      |NULL      |YES
>     COL1_TABLE2         |INTEGER  |0   |10  |10    |NULL      |NULL      |YES
>     
>     2 rows selected
> In case b), it does not make a difference whether the single quotes actually surround a valid table name, some garbage, or nothing at all.
> I must admit that b) seems like a useful feature, listing all columns in all tables in a schema, but it's usage is not very intuitive, nor is it documented, so this may be a bug.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.