You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Roman Khachatryan (Jira)" <ji...@apache.org> on 2020/08/18 17:03:00 UTC
[jira] [Updated] (FLINK-18990) Optimize reading ResultSubpartition state

     [ https://issues.apache.org/jira/browse/FLINK-18990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Roman Khachatryan updated FLINK-18990:
--------------------------------------
    Description: 
Curently, channel state is read not sequentially.

Inverting control would make it more efficient.

Current call chain: 
{code:java}
StreamTask.readRecoveredChannelState  
    ResultPartition.readRecoveredState - loop through subpartitions
        PipelinedSubpartition.readRecoveredState - loop while have data; bufferBuilder = parent.getBufferPool().requestBufferBuilderBlocking(subpartitionInfo.getSubPartitionIdx());
            ChannelStateReader.readOutputData   {code}
Proposed call chain:
{code:java}
StreamTask.readRecoveredChannelState
    ChannelStateReader.readOutputData loop through state handles ordererd by handle, offset
        request buffer in the same way: BufferBuilder bufferBuilder = resPart.getBufferPool().requestBufferBuilderBlocking(subpartitionInfo.getSubPartitionIdx());
        pass to resPart.getSubpartition(idx).add(BufferConsumer, boolean, boolean)
{code}
  Depends on FLINK-18989

  was:
Curently, channel state is read not sequentially.

Inverting control would make it more efficient.

Current call chain:

 
{code:java}
StreamTask.readRecoveredChannelState  
    ResultPartition.readRecoveredState - loop through subpartitions
        PipelinedSubpartition.readRecoveredState - loop while have data; bufferBuilder = parent.getBufferPool().requestBufferBuilderBlocking(subpartitionInfo.getSubPartitionIdx());
            ChannelStateReader.readOutputData   {code}
Proposed call chain:

 
{code:java}
StreamTask.readRecoveredChannelState
 ChannelStateReader.readOutputData loop through state handles ordererd by handle, offset
 request buffer in the same way: BufferBuilder bufferBuilder = resPart.getBufferPool().requestBufferBuilderBlocking(subpartitionInfo.getSubPartitionIdx());
 pass to resPart.getSubpartition(idx).add(BufferConsumer, boolean, boolean)
{code}
 

 

Depends on FLINK-18989


> Optimize reading ResultSubpartition state
> -----------------------------------------
>
>                 Key: FLINK-18990
>                 URL: https://issues.apache.org/jira/browse/FLINK-18990
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Task
>            Reporter: Roman Khachatryan
>            Assignee: Roman Khachatryan
>            Priority: Major
>             Fix For: 1.12.0
>
>
> Curently, channel state is read not sequentially.
> Inverting control would make it more efficient.
> Current call chain: 
> {code:java}
> StreamTask.readRecoveredChannelState  
>     ResultPartition.readRecoveredState - loop through subpartitions
>         PipelinedSubpartition.readRecoveredState - loop while have data; bufferBuilder = parent.getBufferPool().requestBufferBuilderBlocking(subpartitionInfo.getSubPartitionIdx());
>             ChannelStateReader.readOutputData   {code}
> Proposed call chain:
> {code:java}
> StreamTask.readRecoveredChannelState
>     ChannelStateReader.readOutputData loop through state handles ordererd by handle, offset
>         request buffer in the same way: BufferBuilder bufferBuilder = resPart.getBufferPool().requestBufferBuilderBlocking(subpartitionInfo.getSubPartitionIdx());
>         pass to resPart.getSubpartition(idx).add(BufferConsumer, boolean, boolean)
> {code}
>   Depends on FLINK-18989



--
This message was sent by Atlassian Jira
(v8.3.4#803005)