You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by GitBox <gi...@apache.org> on 2022/01/27 07:20:01 UTC
[GitHub] [incubator-age] emotionbug opened a new pull request #181: tests: Move to Github Actions from Travis CI
emotionbug opened a new pull request #181:
URL: https://github.com/apache/incubator-age/pull/181
In Travis CI, the test of the build with `gnu89` format was impossible, so we modify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-age] emotionbug commented on a change in pull request #181: tests: Move to Github Actions from Travis CI
Posted by GitBox <gi...@apache.org>.
emotionbug commented on a change in pull request #181:
URL: https://github.com/apache/incubator-age/pull/181#discussion_r793315377
##########
File path: .github/workflows/installcheck.yml
##########
@@ -0,0 +1,45 @@
+name: Regression
+
+on:
+ push:
+ branches: [ '*' ]
+ pull_request:
+ branches: [ '*' ]
+
+jobs:
+ build:
+
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Get latest commit id of PostgreSQL 11
+ run: |
+ echo "PG_COMMIT_HASH=$(git ls-remote git://git.postgresql.org/git/postgresql.git refs/heads/REL_11_STABLE | awk '{print $1}')" >> $GITHUB_ENV
+
+ - name: Cache PostgreSQL 11
+ uses: actions/cache@v2
+ id: pg11cache
+ with:
+ path: ~/pg11
+ key: ${{ runner.os }}-v1-pg11-${{ env.PG_COMMIT_HASH }}
+
+ - name: Install PostgreSQL 11
+ if: steps.pg11cache.outputs.cache-hit != 'true'
+ run: |
+ git clone --depth 1 --branch REL_11_STABLE git://git.postgresql.org/git/postgresql.git ~/pg11source
+ cd ~/pg11source
+ ./configure --prefix=$HOME/pg11 CFLAGS="-std=gnu89"
Review comment:
Ansi flag can be given, but the comment in the age contains a single comment that is not compatible with ansi(`-ansi`), so specify it as std98(`-std=gnu98`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-age] emotionbug commented on a change in pull request #181: tests: Move to Github Actions from Travis CI
Posted by GitBox <gi...@apache.org>.
emotionbug commented on a change in pull request #181:
URL: https://github.com/apache/incubator-age/pull/181#discussion_r793315377
##########
File path: .github/workflows/installcheck.yml
##########
@@ -0,0 +1,45 @@
+name: Regression
+
+on:
+ push:
+ branches: [ '*' ]
+ pull_request:
+ branches: [ '*' ]
+
+jobs:
+ build:
+
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Get latest commit id of PostgreSQL 11
+ run: |
+ echo "PG_COMMIT_HASH=$(git ls-remote git://git.postgresql.org/git/postgresql.git refs/heads/REL_11_STABLE | awk '{print $1}')" >> $GITHUB_ENV
+
+ - name: Cache PostgreSQL 11
+ uses: actions/cache@v2
+ id: pg11cache
+ with:
+ path: ~/pg11
+ key: ${{ runner.os }}-v1-pg11-${{ env.PG_COMMIT_HASH }}
+
+ - name: Install PostgreSQL 11
+ if: steps.pg11cache.outputs.cache-hit != 'true'
+ run: |
+ git clone --depth 1 --branch REL_11_STABLE git://git.postgresql.org/git/postgresql.git ~/pg11source
+ cd ~/pg11source
+ ./configure --prefix=$HOME/pg11 CFLAGS="-std=gnu89"
Review comment:
Ansiflag can be given, but the comment in the age contains a single comment that is not compatible with ansi(`-ansi`), so specify it as std98(`-std=gnu98`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-age] emotionbug commented on a change in pull request #181: tests: Move to Github Actions from Travis CI
Posted by GitBox <gi...@apache.org>.
emotionbug commented on a change in pull request #181:
URL: https://github.com/apache/incubator-age/pull/181#discussion_r793314641
##########
File path: .github/workflows/installcheck.yml
##########
@@ -0,0 +1,45 @@
+name: Regression
+
+on:
+ push:
+ branches: [ '*' ]
+ pull_request:
+ branches: [ '*' ]
+
+jobs:
+ build:
+
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Get latest commit id of PostgreSQL 11
+ run: |
+ echo "PG_COMMIT_HASH=$(git ls-remote git://git.postgresql.org/git/postgresql.git refs/heads/REL_11_STABLE | awk '{print $1}')" >> $GITHUB_ENV
Review comment:
`REL_11_STABLE` has been specified, but it can be change with the specific version required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-age] emotionbug commented on a change in pull request #181: tests: Move to Github Actions from Travis CI
Posted by GitBox <gi...@apache.org>.
emotionbug commented on a change in pull request #181:
URL: https://github.com/apache/incubator-age/pull/181#discussion_r793313843
##########
File path: Makefile
##########
@@ -92,7 +92,7 @@ EXTRA_CLEAN = $(addprefix $(ag_regress_dir)/, $(ag_regress_out)) src/backend/par
ag_include_dir = $(srcdir)/src/include
PG_CPPFLAGS = -I$(ag_include_dir) -I$(ag_include_dir)/parser
-PG_CONFIG = pg_config
+PG_CONFIG ?= pg_config
Review comment:
Previously, it always assigning a new variable. so, It can't assigning from Shell.
like ```PG_CONFIG=~/pg11/pg_config make -j16```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-age] emotionbug commented on a change in pull request #181: tests: Move to Github Actions from Travis CI
Posted by GitBox <gi...@apache.org>.
emotionbug commented on a change in pull request #181:
URL: https://github.com/apache/incubator-age/pull/181#discussion_r793313843
##########
File path: Makefile
##########
@@ -92,7 +92,7 @@ EXTRA_CLEAN = $(addprefix $(ag_regress_dir)/, $(ag_regress_out)) src/backend/par
ag_include_dir = $(srcdir)/src/include
PG_CPPFLAGS = -I$(ag_include_dir) -I$(ag_include_dir)/parser
-PG_CONFIG = pg_config
+PG_CONFIG ?= pg_config
Review comment:
Previously, it always assigning a new variable. so, It can't assigning from Shell before.
like ```PG_CONFIG=~/pg11/pg_config make -j16```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org