You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/11/20 12:45:42 UTC

[GitHub] [activemq-artemis] cshannon edited a comment on issue #2892: ARTEMIS-2549 - Add Downstream support to Federation

cshannon edited a comment on issue #2892: ARTEMIS-2549 - Add Downstream support to Federation
URL: https://github.com/apache/activemq-artemis/pull/2892#issuecomment-555978629
 
 
   @michaelandrepearce - I just pushed an update an added a new test to FederatedAddress called testDownstreamFederatedAddressReplicationConsumerCounts.   https://github.com/apache/activemq-artemis/commit/31aa464bafa9a8c1f6d6c2861ffc70981aa24199#diff-6585fa255ca2a39e4fa2a48bf28e6947R123
   
   Take a look at that and see if that makes sense, you will see the test break if you revert that conditional method check.  Unfortunately this right now fixes the two downstream case but with two upstreams the extra consumer is still created which I want to fix in another update but is more tricky however I wouldn't expect this change to break existing use cases.
   
   If you still have questions we can chat more, we can setup a call or using Slack might be easier which you can message me on

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services