You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by te...@apache.org on 2013/12/28 16:58:59 UTC

svn commit: r1553857 - /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java

Author: tedyu
Date: Sat Dec 28 15:58:59 2013
New Revision: 1553857

URL: http://svn.apache.org/r1553857
Log:
HBASE-10176 Canary#sniff() should close the HTable instance


Modified:
    hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java

Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java?rev=1553857&r1=1553856&r2=1553857&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java (original)
+++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/tool/Canary.java Sat Dec 28 15:58:59 2013
@@ -472,13 +472,17 @@ public final class Canary implements Too
       return;
     }
 
-    for (HRegionInfo region : admin.getTableRegions(tableDesc.getName())) {
-      try {
-        sniffRegion(admin, sink, region, table);
-      } catch (Exception e) {
-        sink.publishReadFailure(region, e);
-        LOG.debug("sniffRegion failed", e);
+    try {
+      for (HRegionInfo region : admin.getTableRegions(tableDesc.getName())) {
+        try {
+          sniffRegion(admin, sink, region, table);
+        } catch (Exception e) {
+          sink.publishReadFailure(region, e);
+          LOG.debug("sniffRegion failed", e);
+        }
       }
+    } finally {
+      table.close();
     }
   }