You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "absurdfarce (via GitHub)" <gi...@apache.org> on 2024/11/06 23:49:27 UTC

[PR] CASSJAVA-54 Update Cassandra/DSE/Java versions in DataStax Jenkinsfile [cassandra-java-driver]

absurdfarce opened a new pull request, #1984:
URL: https://github.com/apache/cassandra-java-driver/pull/1984

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSJAVA-54 Update Cassandra/DSE/Java versions in DataStax Jenkinsfile [cassandra-java-driver]

Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on code in PR #1984:
URL: https://github.com/apache/cassandra-java-driver/pull/1984#discussion_r1831873061


##########
Jenkinsfile-datastax:
##########
@@ -292,14 +288,6 @@ pipeline {
                           <th align="left">Choice</th>
                           <th align="left">Description</th>
                         </tr>
-                        <tr>
-                          <td><strong>2.1</strong></td>
-                          <td>Apache Cassandra&reg; v2.1.x</td>
-                        </tr>
-                        <tr>
-                          <td><strong>2.2</strong></td>
-                          <td>Apache Cassandra&reg; v2.2.x</td>
-                        </tr>

Review Comment:
   According to the driver readme we should also be supporting these as well but (a) they're also EOL (and thus prolly excluded based on the logic above) and (b) the ASF CI is canonical for these versions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSJAVA-54 Update Cassandra versions in DataStax Jenkinsfile [cassandra-java-driver]

Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on PR #1984:
URL: https://github.com/apache/cassandra-java-driver/pull/1984#issuecomment-2471730059

   @lukasz-antoniak and/or @SiyaoIsHiding can one or both of you take a quick look at this and let me know if you're onboard?  This change only affects the DataStax Jenkinsfile so I'm okay with moving forward with my +1 in this case but I would very much like to get a vote of approval from somebody other than me before I push the Big Green Button :tm:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSJAVA-54 Update Cassandra/DSE/Java versions in DataStax Jenkinsfile [cassandra-java-driver]

Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on code in PR #1984:
URL: https://github.com/apache/cassandra-java-driver/pull/1984#discussion_r1831872209


##########
Jenkinsfile-datastax:
##########
@@ -274,12 +274,8 @@ pipeline {
                 '3.11',      // Previous Apache CassandraⓇ
                 '4.0',       // Previous Apache CassandraⓇ
                 '4.1',       // Current Apache CassandraⓇ
-                '5.0-beta1',    // Development Apache CassandraⓇ
-                'dse-4.8.16',   // Previous EOSL DataStax Enterprise
-                'dse-5.0.15',   // Long Term Support DataStax Enterprise
+                '5.0',       // Development Apache CassandraⓇ
                 'dse-5.1.35',   // Legacy DataStax Enterprise
-                'dse-6.0.18',   // Previous DataStax Enterprise
-                'dse-6.7.17',   // Previous DataStax Enterprise

Review Comment:
   This might be too aggressive.  The top-level readme for the driver says that we support C* 2.1 and up as well as DSE 4.8.x and up.  The four releases above are now EOL and we did decide that we were going to follow the DataStax drivers policy of only supporting releases that weren't EOL at time of release... so I decided to yank these.
   
   At a minimum we should probably update the readme to be clearer about our policy if we choose to move forward with these.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSJAVA-54 Update Cassandra/DSE/Java versions in DataStax Jenkinsfile [cassandra-java-driver]

Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on code in PR #1984:
URL: https://github.com/apache/cassandra-java-driver/pull/1984#discussion_r1834862424


##########
Jenkinsfile-datastax:
##########
@@ -274,12 +274,8 @@ pipeline {
                 '3.11',      // Previous Apache CassandraⓇ
                 '4.0',       // Previous Apache CassandraⓇ
                 '4.1',       // Current Apache CassandraⓇ
-                '5.0-beta1',    // Development Apache CassandraⓇ
-                'dse-4.8.16',   // Previous EOSL DataStax Enterprise
-                'dse-5.0.15',   // Long Term Support DataStax Enterprise
+                '5.0',       // Development Apache CassandraⓇ
                 'dse-5.1.35',   // Legacy DataStax Enterprise
-                'dse-6.0.18',   // Previous DataStax Enterprise
-                'dse-6.7.17',   // Previous DataStax Enterprise

Review Comment:
   The alternative that I'm considering is that we can just update 5.0 and remove the EOL Apache Cassandra versions now.  Apache C* is properly covered by the ASF CI and this is just a "backup" for that.... and if we're just testing EOL versions that should be adequate.  Neither of those changes require an update to the support policy.
   
   We can change the DSE versions later after we have some consensus around the approach the project will take re: backend support.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSJAVA-54 Update Cassandra versions in DataStax Jenkinsfile [cassandra-java-driver]

Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce merged PR #1984:
URL: https://github.com/apache/cassandra-java-driver/pull/1984


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSJAVA-54 Update Cassandra versions in DataStax Jenkinsfile [cassandra-java-driver]

Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on PR #1984:
URL: https://github.com/apache/cassandra-java-driver/pull/1984#issuecomment-2474189919

   Thanks @SiyaoIsHiding!  With that comment I'm calling this good.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSJAVA-54 Update Cassandra/DSE/Java versions in DataStax Jenkinsfile [cassandra-java-driver]

Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on code in PR #1984:
URL: https://github.com/apache/cassandra-java-driver/pull/1984#discussion_r1831873061


##########
Jenkinsfile-datastax:
##########
@@ -292,14 +288,6 @@ pipeline {
                           <th align="left">Choice</th>
                           <th align="left">Description</th>
                         </tr>
-                        <tr>
-                          <td><strong>2.1</strong></td>
-                          <td>Apache Cassandra&reg; v2.1.x</td>
-                        </tr>
-                        <tr>
-                          <td><strong>2.2</strong></td>
-                          <td>Apache Cassandra&reg; v2.2.x</td>
-                        </tr>

Review Comment:
   According to the driver readme we should also be supporting these as well but (a) they're also EOL (and thus prolly excluded based on the logic above) and (b) the ASF CI is canonical for these versions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSJAVA-54 Update Cassandra/DSE/Java versions in DataStax Jenkinsfile [cassandra-java-driver]

Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on code in PR #1984:
URL: https://github.com/apache/cassandra-java-driver/pull/1984#discussion_r1831874448


##########
Jenkinsfile-datastax:
##########
@@ -371,30 +343,10 @@ pipeline {
                           <td><strong>1.8</strong></td>
                           <td>Oracle JDK version 1.8 (<i>Used for compiling regardless of choice</i>)</td>
                         </tr>
-                        <tr>
-                          <td><strong>openjdk@1.9</strong></td>
-                          <td>OpenJDK version 9</td>
-                        </tr>
-                        <tr>
-                          <td><strong>openjdk@1.10</strong></td>
-                          <td>OpenJDK version 10</td>
-                        </tr>
                         <tr>
                           <td><strong>openjdk@1.11</strong></td>
                           <td>OpenJDK version 11</td>
                         </tr>
-                        <tr>
-                          <td><strong>openjdk@1.12</strong></td>
-                          <td>OpenJDK version 12</td>
-                        </tr>
-                        <tr>
-                          <td><strong>openjdk@1.13</strong></td>
-                          <td>OpenJDK version 13</td>
-                        </tr>
-                        <tr>
-                          <td><strong>openjdk@1.14</strong></td>
-                          <td>OpenJDK version 14</td>
-                        </tr>

Review Comment:
   Non-LTS versions which are already EOL.  We also aren't aiming to explicitly support anything that isn't an LTS Java release so in the interest of keeping this simple I just yanked all of these.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSJAVA-54 Update Cassandra versions in DataStax Jenkinsfile [cassandra-java-driver]

Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on PR #1984:
URL: https://github.com/apache/cassandra-java-driver/pull/1984#issuecomment-2468715453

   Scaled back version of original idea.  For now we just remove the EOL Apache Cassandra releases from this Jenkinsfile.  Removing either DSE or Java versions will require a change in our support policy and that needs further dicsussion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSJAVA-54 Update Cassandra/DSE/Java versions in DataStax Jenkinsfile [cassandra-java-driver]

Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on code in PR #1984:
URL: https://github.com/apache/cassandra-java-driver/pull/1984#discussion_r1834862424


##########
Jenkinsfile-datastax:
##########
@@ -274,12 +274,8 @@ pipeline {
                 '3.11',      // Previous Apache CassandraⓇ
                 '4.0',       // Previous Apache CassandraⓇ
                 '4.1',       // Current Apache CassandraⓇ
-                '5.0-beta1',    // Development Apache CassandraⓇ
-                'dse-4.8.16',   // Previous EOSL DataStax Enterprise
-                'dse-5.0.15',   // Long Term Support DataStax Enterprise
+                '5.0',       // Development Apache CassandraⓇ
                 'dse-5.1.35',   // Legacy DataStax Enterprise
-                'dse-6.0.18',   // Previous DataStax Enterprise
-                'dse-6.7.17',   // Previous DataStax Enterprise

Review Comment:
   The alternative that I'm considering is that we can just update 5.0 and remove the non-EOL Apache Cassandra versions now; those are properly covered by the ASF CI and this is just a "backup" for that.  Neither of those changes require an update to the support policy.
   
   We can change the DSE versions later after we have some consensus around the approach the project will take re: backend support.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org


Re: [PR] CASSJAVA-54 Update Cassandra/DSE/Java versions in DataStax Jenkinsfile [cassandra-java-driver]

Posted by "lukasz-antoniak (via GitHub)" <gi...@apache.org>.
lukasz-antoniak commented on code in PR #1984:
URL: https://github.com/apache/cassandra-java-driver/pull/1984#discussion_r1832223442


##########
Jenkinsfile-datastax:
##########
@@ -274,12 +274,8 @@ pipeline {
                 '3.11',      // Previous Apache CassandraⓇ
                 '4.0',       // Previous Apache CassandraⓇ
                 '4.1',       // Current Apache CassandraⓇ
-                '5.0-beta1',    // Development Apache CassandraⓇ
-                'dse-4.8.16',   // Previous EOSL DataStax Enterprise
-                'dse-5.0.15',   // Long Term Support DataStax Enterprise
+                '5.0',       // Development Apache CassandraⓇ
                 'dse-5.1.35',   // Legacy DataStax Enterprise
-                'dse-6.0.18',   // Previous DataStax Enterprise
-                'dse-6.7.17',   // Previous DataStax Enterprise

Review Comment:
   I guess we do not need to explicitly mention policy, but update versions in README would be enough.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org