You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/05 13:26:25 UTC

[GitHub] [incubator-doris] jackwener commented on a diff in pull request #8780: complement the SHOW PROCESSLIST information

jackwener commented on code in PR #8780:
URL: https://github.com/apache/incubator-doris/pull/8780#discussion_r842777069


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ShowProcesslistStmt.java:
##########
@@ -32,10 +32,12 @@
                     .addColumn(new Column("Host", ScalarType.createVarchar(16)))
                     .addColumn(new Column("Cluster", ScalarType.createVarchar(16)))
                     .addColumn(new Column("Db", ScalarType.createVarchar(16)))
+                    .addColumn(new Column("QueryId", ScalarType.createVarchar(64)))
                     .addColumn(new Column("Command", ScalarType.createVarchar(16)))
+                    .addColumn(new Column("StartTime", ScalarType.createType(PrimitiveType.DATETIME)))
                     .addColumn(new Column("Time", ScalarType.createType(PrimitiveType.INT)))
                     .addColumn(new Column("State", ScalarType.createVarchar(64)))
-                    .addColumn(new Column("Info", ScalarType.createVarchar(16)))
+                    .addColumn(new Column("Info", ScalarType.createVarchar(32 * 1024)))

Review Comment:
   This change of size need to be discussed. @EmmyMiao87 



##########
fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java:
##########
@@ -549,12 +551,24 @@ public String getRemoteIp() {
             row.add(getMysqlChannel().getRemoteHostPortString());
             row.add(clusterName);
             row.add(ClusterNamespace.getNameFromFullName(currentDb));
+                        row.add(queryDetail.getQueryId());
             row.add(command.toString());
+            row.add(fromLongToDate(startTime));
             row.add("" + (nowMs - startTime) / 1000);
             row.add("");
-            row.add("");
+            String stmt = "";
+            if (executor != null){
+                stmt = executor.getOriginStmtInString();
+            }

Review Comment:
   ```suggestion
               String stmt = executor == null ? "" : executor.getOriginStmtInString();
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org