[GitHub] [airflow] bperson commented on a change in pull request #15247: Infinite pools: Make their `total_slots` be `maxint`-like instead of `-1`

[GitBox <gi...@apache.org>]

bperson commented on a change in pull request #15247:
URL: https://github.com/apache/airflow/pull/15247#discussion_r645578585



##########
File path: airflow/models/pool.py
##########
@@ -106,6 +107,8 @@ def slots_stats(
 
         pool_rows: Iterable[Tuple[str, int]] = query.all()
         for (pool_name, total_slots) in pool_rows:
+            if total_slots == -1:
+                total_slots = maxsize

Review comment:
       Great idea, and existing log end up pretty solid too:
   ```
   [2021-06-04 13:37:28,963] {scheduler_job.py:993} INFO - Figuring out tasks to run in Pool(name=infinite_pool) with inf open slots and 1 task instances ready to be queued
   [2021-06-04 13:37:28,963] {scheduler_job.py:1021} INFO - DAG SchedulerJobTest.test_infinite_pool has 0/16 running and queued tasks
   [2021-06-04 13:37:28,963] {scheduler_job.py:1086} INFO - Setting the following tasks to queued state:
   	<TaskInstance: SchedulerJobTest.test_infinite_pool.dummy 2016-01-01 00:00:00+00:00 [scheduled]>
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org