You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@tsfile.apache.org by "JackieTien97 (via GitHub)" <gi...@apache.org> on 2024/09/11 08:56:51 UTC
[PR] Add TableChunkReader and TablePageReader to support keep all null rows while scanning [tsfile]
JackieTien97 opened a new pull request, #239:
URL: https://github.com/apache/tsfile/pull/239
Add TableChunkReader and TablePageReader to support keep all null rows while scanning which can be useful in table model of iotdb.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add TableChunkReader and TablePageReader to support keep all null rows while scanning [tsfile]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #239:
URL: https://github.com/apache/tsfile/pull/239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add TableChunkReader and TablePageReader to support keep all null rows while scanning [tsfile]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #239:
URL: https://github.com/apache/tsfile/pull/239#issuecomment-2343095142
## [Codecov](https://app.codecov.io/gh/apache/tsfile/pull/239?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `63.65915%` with `145 lines` in your changes missing coverage. Please review.
> Project coverage is 62.24%. Comparing base [(`cd418aa`)](https://app.codecov.io/gh/apache/tsfile/commit/cd418aa99771c35378f278985447d39fbbc3e67d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`51cf130`)](https://app.codecov.io/gh/apache/tsfile/commit/51cf1309e7ca46d49fec437ac7232b1c19dd7869?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 2 commits behind head on develop.
| [Files with missing lines](https://app.codecov.io/gh/apache/tsfile/pull/239?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...le/metadata/AbstractAlignedTimeSeriesMetadata.java](https://app.codecov.io/gh/apache/tsfile/pull/239?src=pr&el=tree&filepath=java%2Ftsfile%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftsfile%2Ffile%2Fmetadata%2FAbstractAlignedTimeSeriesMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-amF2YS90c2ZpbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RzZmlsZS9maWxlL21ldGFkYXRhL0Fic3RyYWN0QWxpZ25lZFRpbWVTZXJpZXNNZXRhZGF0YS5qYXZh) | 35.29% | [44 Missing :warning: ](https://app.codecov.io/gh/apache/tsfile/pull/239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../read/reader/chunk/AbstractAlignedChunkReader.java](https://app.codecov.io/gh/apache/tsfile/pull/239?src=pr&el=tree&filepath=java%2Ftsfile%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftsfile%2Fread%2Freader%2Fchunk%2FAbstractAlignedChunkReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-amF2YS90c2ZpbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RzZmlsZS9yZWFkL3JlYWRlci9jaHVuay9BYnN0cmFjdEFsaWduZWRDaHVua1JlYWRlci5qYXZh) | 73.10% | [32 Missing :warning: ](https://app.codecov.io/gh/apache/tsfile/pull/239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/tsfile/read/reader/page/TablePageReader.java](https://app.codecov.io/gh/apache/tsfile/pull/239?src=pr&el=tree&filepath=java%2Ftsfile%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftsfile%2Fread%2Freader%2Fpage%2FTablePageReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-amF2YS90c2ZpbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RzZmlsZS9yZWFkL3JlYWRlci9wYWdlL1RhYmxlUGFnZVJlYWRlci5qYXZh) | 0.00% | [30 Missing :warning: ](https://app.codecov.io/gh/apache/tsfile/pull/239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...le/read/reader/page/AbstractAlignedPageReader.java](https://app.codecov.io/gh/apache/tsfile/pull/239?src=pr&el=tree&filepath=java%2Ftsfile%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftsfile%2Fread%2Freader%2Fpage%2FAbstractAlignedPageReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-amF2YS90c2ZpbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RzZmlsZS9yZWFkL3JlYWRlci9wYWdlL0Fic3RyYWN0QWxpZ25lZFBhZ2VSZWFkZXIuamF2YQ==) | 87.50% | [19 Missing :warning: ](https://app.codecov.io/gh/apache/tsfile/pull/239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/tsfile/read/reader/chunk/TableChunkReader.java](https://app.codecov.io/gh/apache/tsfile/pull/239?src=pr&el=tree&filepath=java%2Ftsfile%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftsfile%2Fread%2Freader%2Fchunk%2FTableChunkReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-amF2YS90c2ZpbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RzZmlsZS9yZWFkL3JlYWRlci9jaHVuay9UYWJsZUNodW5rUmVhZGVyLmphdmE=) | 0.00% | [11 Missing :warning: ](https://app.codecov.io/gh/apache/tsfile/pull/239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/tsfile/file/metadata/TableDeviceMetadata.java](https://app.codecov.io/gh/apache/tsfile/pull/239?src=pr&el=tree&filepath=java%2Ftsfile%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftsfile%2Ffile%2Fmetadata%2FTableDeviceMetadata.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-amF2YS90c2ZpbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RzZmlsZS9maWxlL21ldGFkYXRhL1RhYmxlRGV2aWNlTWV0YWRhdGEuamF2YQ==) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/tsfile/pull/239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/tsfile/read/reader/page/ValuePageReader.java](https://app.codecov.io/gh/apache/tsfile/pull/239?src=pr&el=tree&filepath=java%2Ftsfile%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftsfile%2Fread%2Freader%2Fpage%2FValuePageReader.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-amF2YS90c2ZpbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RzZmlsZS9yZWFkL3JlYWRlci9wYWdlL1ZhbHVlUGFnZVJlYWRlci5qYXZh) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/tsfile/pull/239?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #239 +/- ##
===========================================
- Coverage 62.28% 62.24% -0.04%
===========================================
Files 476 482 +6
Lines 31600 31727 +127
Branches 4107 4116 +9
===========================================
+ Hits 19681 19748 +67
- Misses 11472 11532 +60
Partials 447 447
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tsfile/pull/239?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org