You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/01 10:59:52 UTC

[GitHub] [cloudstack] ravening opened a new pull request #4634: Display vlan ip range for specified domainid

ravening opened a new pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634


   ### Description
   Currently if we try to list vlan ip range by passing
   domainid then it lists for all domain. Make sure that
   it lists only for that domain
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [X] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [X] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   Before the changes
   
   ```
   (local) 🐱 > list vlanipranges domainid=4aa4c-f694-45c0-8844-8d9a129
   {
     "count": 14,
     "vlaniprange": [
   ```
   
   After the changes
   ```
   (local) 🐱 > list vlanipranges domainid=4560c-f694-45c0-8844-8d94129
   {
     "count": 1,
     "vlaniprange": [
   ```
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-921208115


   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-920590365


   If it's fixing a bug then +1 (sounds like you can't list Vlans for a domain?) but this would need testing 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-770778375


   @ravening, do you intend this for master/4.16 only or do you want this on older versions?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache closed pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-921545043


   @blueorangutan test
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] ravening commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-900924374


   > > > no comment on this PR but all this `DAO` code really shouldn't be in the `ManagementServer`
   > > 
   > > 
   > > @DaanHoogland any idea where else I can add this ?
   > 
   > `DomainVlanMapDaoImpl`, i'd say.
   
   @DaanHoogland Im using the same code which is used by `account` and `pod` also which are present above and below of this code. So even they needs to be moved away?
   
   I searched in other places in the same file and they are also using the same logic. for eg: publicipaddress, loadbalancer, resourcetag, vlan, guestos


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-918847002


   Ping @ravening can you address review and fix conflicts, thanks 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] ravening commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-900924374


   > > > no comment on this PR but all this `DAO` code really shouldn't be in the `ManagementServer`
   > > 
   > > 
   > > @DaanHoogland any idea where else I can add this ?
   > 
   > `DomainVlanMapDaoImpl`, i'd say.
   
   @DaanHoogland Im using the same code which is used by `account` and `pod` also which are present above and below of this code. So even they needs to be moved away?
   
   I searched in other places in the same file and they are also using the same logic. for eg: publicipaddress, loadbalancer, resourcetag, vlan, guestos


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-920599094


   @davidjumani a Trillian-Jenkins test job (suse15 mgmt + kvm-suse15) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-920596901


   Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1282


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] ravening commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-770778907


   > @ravening, do you intend this for master/4.16 only or do you want this on older versions?
   
   @DaanHoogland 4.16 is good


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-920566216


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-919807843


   > > > > > > > no comment on this PR but all this `DAO` code really shouldn't be in the `ManagementServer`
   > > > > > > 
   > > > > > > 
   > > > > > > @DaanHoogland any idea where else I can add this ?
   > > > > > 
   > > > > > 
   > > > > > `DomainVlanMapDaoImpl`, i'd say.
   > > > > 
   > > > > 
   > > > > @DaanHoogland Im using the same code which is used by `account` and `pod` also which are present above and below of this code. So even they needs to be moved away?
   > > > > I searched in other places in the same file and they are also using the same logic. for eg: publicipaddress, loadbalancer, resourcetag, vlan, guestos
   > > > 
   > > > 
   > > > @ravening the rest of the code is not perfect and should be in DAOs as well. I'm not asking that of you now as I don't expect you to fix everything in one go, just to not add to the technical debt we have.
   > > 
   > > 
   > > @DaanHoogland
   > > there are more than ten Dao.search() or Dao.searchAndCount() in ManagementServerImpl.java, and much more in QueryManagerImpl.java
   > > we do not need to move everything into DAO, especially for the searches in multiple (more than 2) tables.
   > 
   > no, but those single table transactions that can we should.
   
   @DaanHoogland agree .
   
   as you can see in the code changes of this pr, the search on vlans has some join tables (DomainVlanMapDao, AccountVlanMapDao, PodVlanMapDao)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-921533205


   <b>Trillian test result (tid-2098)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35205 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4634-t2098-kvm-centos7.zip
   Smoke tests completed. 84 look OK, 5 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_nic | `Error` | 135.77 | test_nic.py
   test_01_add_primary_storage_disabled_host | `Error` | 0.57 | test_primary_storage.py
   test_01_primary_storage_nfs | `Error` | 0.12 | test_primary_storage.py
   ContextSuite context=TestStorageTags>:setup | `Error` | 0.21 | test_primary_storage.py
   test_02_list_snapshots_with_removed_data_store | `Error` | 1.17 | test_snapshots.py
   test_01_secure_vm_migration | `Error` | 156.38 | test_vm_life_cycle.py
   test_02_unsecure_vm_migration | `Error` | 271.97 | test_vm_life_cycle.py
   test_03_secured_to_nonsecured_vm_migration | `Error` | 148.02 | test_vm_life_cycle.py
   test_08_migrate_vm | `Error` | 43.69 | test_vm_life_cycle.py
   test_hostha_enable_ha_when_host_in_maintenance | `Error` | 305.13 | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-889980940


   > > no comment on this PR but all this `DAO` code really shouldn't be in the `ManagementServer`
   > 
   > @DaanHoogland any idea where else I can add this ?
   
   `DomainVlanMapDaoImpl`, i'd say.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-897323998


   @ravening can you move the logic to the DAO layer and fix the conflicts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] ravening commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-918885249


   > Ping @ravening can you address review and fix conflicts, thanks
   
   @rhtyd done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-921953813


   <b>Trillian test result (tid-2107)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 35409 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4634-t2107-kvm-centos7.zip
   Smoke tests completed. 89 look OK, 0 have errors
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-901138876


   > > > > no comment on this PR but all this `DAO` code really shouldn't be in the `ManagementServer`
   > > > 
   > > > 
   > > > @DaanHoogland any idea where else I can add this ?
   > > 
   > > 
   > > `DomainVlanMapDaoImpl`, i'd say.
   > 
   > @DaanHoogland Im using the same code which is used by `account` and `pod` also which are present above and below of this code. So even they needs to be moved away?
   > 
   > I searched in other places in the same file and they are also using the same logic. for eg: publicipaddress, loadbalancer, resourcetag, vlan, guestos
   
   @ravening the rest of the code is not perfect and should be in DAOs as well. I'm not asking that of you now as I don't expect you to fix everything in one go, just to not add to the technical debt we have.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti merged pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] davidjumani commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-920598715


   @blueorangutan test suse15 kvm-suse15


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-919804206


   > > > > > > no comment on this PR but all this `DAO` code really shouldn't be in the `ManagementServer`
   > > > > > 
   > > > > > 
   > > > > > @DaanHoogland any idea where else I can add this ?
   > > > > 
   > > > > 
   > > > > `DomainVlanMapDaoImpl`, i'd say.
   > > > 
   > > > 
   > > > @DaanHoogland Im using the same code which is used by `account` and `pod` also which are present above and below of this code. So even they needs to be moved away?
   > > > I searched in other places in the same file and they are also using the same logic. for eg: publicipaddress, loadbalancer, resourcetag, vlan, guestos
   > > 
   > > 
   > > @ravening the rest of the code is not perfect and should be in DAOs as well. I'm not asking that of you now as I don't expect you to fix everything in one go, just to not add to the technical debt we have.
   > 
   > @DaanHoogland
   > 
   > there are more than ten Dao.search() or Dao.searchAndCount() in ManagementServerImpl.java, and much more in QueryManagerImpl.java
   > we do not need to move everything into DAO, especially for the searches in multiple (more than 2) tables.
   
   no, but those single table transactions that can we should.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-921545359


   @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-921195817


   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1291


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-921426386


   Manually tested + 2xLGTM - ready for merge after tests pass


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-918864973


   > > > > > no comment on this PR but all this `DAO` code really shouldn't be in the `ManagementServer`
   > > > > 
   > > > > 
   > > > > @DaanHoogland any idea where else I can add this ?
   > > > 
   > > > 
   > > > `DomainVlanMapDaoImpl`, i'd say.
   > > 
   > > 
   > > @DaanHoogland Im using the same code which is used by `account` and `pod` also which are present above and below of this code. So even they needs to be moved away?
   > > I searched in other places in the same file and they are also using the same logic. for eg: publicipaddress, loadbalancer, resourcetag, vlan, guestos
   > 
   > @ravening the rest of the code is not perfect and should be in DAOs as well. I'm not asking that of you now as I don't expect you to fix everything in one go, just to not add to the technical debt we have.
   
   @DaanHoogland 
    
   there are more than ten Dao.search() or Dao.searchAndCount() in ManagementServerImpl.java, and much more in QueryManagerImpl.java
   we do not need to move everything into DAO, especially for the searches in multiple (more than 2) tables.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-922640280


   > Manually tested + 2xLGTM - ready for merge after tests pass
   
   Merging based on LGTMs, and manual / smoke tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-921179819


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] ravening commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-889689943


   > no comment on this PR but all this `DAO` code really shouldn't be in the `ManagementServer`
   
   @DaanHoogland any idea where else I can add this ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-921660539


   -0 if we allow for a mix of concerns in manager implementations we will increase the number of code conflict we will get over time. We should strive for better separation as much as possible. I'm not going to block this simple fix over this but it is an increasing concern. Calls to DAOs could have been made.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sureshanaparti commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-922639859


   > -0 if we allow for a mix of concerns in manager implementations we will increase the number of code conflict we will get over time. We should strive for better separation as much as possible. I'm not going to block this simple fix over this but it is an increasing concern. Calls to DAOs could have been made.
   
   @DaanHoogland want to add this to cwiki / issues (as improvement) to track it later?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-921208439


   @sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-920566137


   @DaanHoogland @weizhouapache let's get a consensus on this PR to try moving it forward as it seems the requested changes may not be applied. Would that be a reason for a -1 on this PR for any of you?
   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-889981622


   @ravening you have a new conflict


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-901138876


   > > > > no comment on this PR but all this `DAO` code really shouldn't be in the `ManagementServer`
   > > > 
   > > > 
   > > > @DaanHoogland any idea where else I can add this ?
   > > 
   > > 
   > > `DomainVlanMapDaoImpl`, i'd say.
   > 
   > @DaanHoogland Im using the same code which is used by `account` and `pod` also which are present above and below of this code. So even they needs to be moved away?
   > 
   > I searched in other places in the same file and they are also using the same logic. for eg: publicipaddress, loadbalancer, resourcetag, vlan, guestos
   
   @ravening the rest of the code is not perfect and should be in DAOs as well. I'm not asking that of you now as I don't expect you to fix everything in one go, just to not add to the technical debt we have.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4634: Display vlan ip range for specified domainid

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4634:
URL: https://github.com/apache/cloudstack/pull/4634#issuecomment-921180311


   @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org