You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com> on 2013/03/28 00:26:22 UTC
Review Request: Remove db id in exception message.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10159/
-----------------------------------------------------------
Review request for cloudstack, mice xia and Min Chen.
Description
-------
Replacing db id by uuid of the domain in exception message.
This addresses bug CLOUDSTACK-1675.
Diffs
-----
server/src/com/cloud/user/AccountManagerImpl.java b69f314
Diff: https://reviews.apache.org/r/10159/diff/
Testing
-------
With the changes in place, a listVMSnapshot command sent in with an invalid account id now returns the uuid of the domain in the response:
# curl --request GET 'http://10.223.76.20:8096/client/api?command=listVMSnapshot&listAll=true&account=c896cef6-2e69-47cd-8bdb-9f963b4053d8&domainid=26481c20-96f8-11e2-afa5-000c29db3315&response=json'
{ "listvmsnapshotresponse" : {"errorcode":431,"cserrorcode":4350,"errortext":"could not find account c896cef6-2e69-47cd-8bdb-9f963b4053d8 in domain 26481c20-96f8-11e2-afa5-000c29db3315"} }
#
Thanks,
Venkata Siva Vijayendra Bhamidipati
Re: Review Request: Remove db id in exception message.
Posted by Rohit Yadav <bh...@apache.org>.
> On April 10, 2013, 1:58 a.m., mice xia wrote:
> > Ship It!
Applied on master;
commit d4e2aa32c6555971312fab47c45eef23b57579d1
Author: Vijayendra Bhamidipati <vi...@citrix.com>
Date: Wed Mar 27 09:33:00 2013 -0700
CLOUDSTACK-1675: VMSnapshot: ListVMSnapshotsCmd should not display Domain ID in the Error Message
Description:
Replace domain db id by uuid in exception message.
Signed-off-by: Mice Xia <mi...@tcloudcomputing.com>
- Rohit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10159/#review18920
-----------------------------------------------------------
On March 27, 2013, 11:26 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10159/
> -----------------------------------------------------------
>
> (Updated March 27, 2013, 11:26 p.m.)
>
>
> Review request for cloudstack, mice xia and Min Chen.
>
>
> Description
> -------
>
> Replacing db id by uuid of the domain in exception message.
>
>
> This addresses bug CLOUDSTACK-1675.
>
>
> Diffs
> -----
>
> server/src/com/cloud/user/AccountManagerImpl.java b69f314
>
> Diff: https://reviews.apache.org/r/10159/diff/
>
>
> Testing
> -------
>
> With the changes in place, a listVMSnapshot command sent in with an invalid account id now returns the uuid of the domain in the response:
>
> # curl --request GET 'http://10.223.76.20:8096/client/api?command=listVMSnapshot&listAll=true&account=c896cef6-2e69-47cd-8bdb-9f963b4053d8&domainid=26481c20-96f8-11e2-afa5-000c29db3315&response=json'
> { "listvmsnapshotresponse" : {"errorcode":431,"cserrorcode":4350,"errortext":"could not find account c896cef6-2e69-47cd-8bdb-9f963b4053d8 in domain 26481c20-96f8-11e2-afa5-000c29db3315"} }
> #
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>
Re: Review Request: Remove db id in exception message.
Posted by mice xia <mi...@tcloudcomputing.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10159/#review18920
-----------------------------------------------------------
Ship it!
Ship It!
- mice xia
On March 27, 2013, 11:26 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10159/
> -----------------------------------------------------------
>
> (Updated March 27, 2013, 11:26 p.m.)
>
>
> Review request for cloudstack, mice xia and Min Chen.
>
>
> Description
> -------
>
> Replacing db id by uuid of the domain in exception message.
>
>
> This addresses bug CLOUDSTACK-1675.
>
>
> Diffs
> -----
>
> server/src/com/cloud/user/AccountManagerImpl.java b69f314
>
> Diff: https://reviews.apache.org/r/10159/diff/
>
>
> Testing
> -------
>
> With the changes in place, a listVMSnapshot command sent in with an invalid account id now returns the uuid of the domain in the response:
>
> # curl --request GET 'http://10.223.76.20:8096/client/api?command=listVMSnapshot&listAll=true&account=c896cef6-2e69-47cd-8bdb-9f963b4053d8&domainid=26481c20-96f8-11e2-afa5-000c29db3315&response=json'
> { "listvmsnapshotresponse" : {"errorcode":431,"cserrorcode":4350,"errortext":"could not find account c896cef6-2e69-47cd-8bdb-9f963b4053d8 in domain 26481c20-96f8-11e2-afa5-000c29db3315"} }
> #
>
>
> Thanks,
>
> Venkata Siva Vijayendra Bhamidipati
>
>