[GitHub] [maven-integration-testing] gnodet commented on a diff in pull request #176: Move ITs to JDK 8 / JUnit 5

[GitBox <gi...@apache.org>]

gnodet commented on code in PR #176:
URL: https://github.com/apache/maven-integration-testing/pull/176#discussion_r906094847


##########
core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java:
##########
@@ -78,7 +79,7 @@ public static Test suite()
             IOUtil.close( info );
         }
 
-        TestSuite suite = new TestSuite();
+        ClassOrderingData suite = new ClassOrderingData();

Review Comment:
   It keeps the existing ordering of the tests.  I also wanted to minimize the code changes, but this leads to somewhat weird code.  I think I'll remove the whole `IntegrationTestSuite` class and implement an ordering based on reverse it number.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org