You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/06/21 16:35:16 UTC
[GitHub] [camel-k-examples] KuthumiPepple opened a new pull request, #55: fix and improve amqp example
KuthumiPepple opened a new pull request, #55:
URL: https://github.com/apache/camel-k-examples/pull/55
@delawen @squakez @oscerd I fixed some errors and provided some contexts for the examples. The examples appear to run fine. Please kindly review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-examples] KuthumiPepple commented on a diff in pull request #55: fix and improve amqp example
Posted by GitBox <gi...@apache.org>.
KuthumiPepple commented on code in PR #55:
URL: https://github.com/apache/camel-k-examples/pull/55#discussion_r903483939
##########
generic-examples/amqp/README.md:
##########
@@ -1,5 +1,46 @@
# AMQP Camel K examples
-Find useful examples about how to use AMQP in a Camel K integration.
+These examples demonstrate how to use AMQP in a Camel K integration.
-You may find useful instructions [how to install a JMS/AMQP Broker on Kubernetes](./artemis/) for demo purposes.
\ No newline at end of file
+You can find more information about Apache Camel and Apache Camel K on the [official Camel website](https://camel.apache.org).
+
+## Before you begin
+
+Read the general instructions in the [root README.md file](/README.md) for setting up your environment and the Kubernetes cluster before looking at this example.
+
+Make sure you've read the [installation instructions](https://camel.apache.org/camel-k/latest/installation/installation.html) for your specific
+cluster before starting the example.
+
+## Additional Requirements for running this example
+
+**An AMQP Broker**: needed MoM for running the examples. For installation instructions, see [how to install a JMS/AMQP Broker on Kubernetes](./artemis/) for demo purposes.
+
+## Understanding the Example
+[`AmqpConnectionBeanProducer.java`](./AmqpConnectionBeanProducer.java) defines a route that generates a message every second and sends it to an amqp queue. \
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-examples] tadayosi commented on a diff in pull request #55: fix and improve amqp example
Posted by GitBox <gi...@apache.org>.
tadayosi commented on code in PR #55:
URL: https://github.com/apache/camel-k-examples/pull/55#discussion_r903287995
##########
generic-examples/amqp/README.md:
##########
@@ -1,5 +1,46 @@
# AMQP Camel K examples
-Find useful examples about how to use AMQP in a Camel K integration.
+These examples demonstrate how to use AMQP in a Camel K integration.
-You may find useful instructions [how to install a JMS/AMQP Broker on Kubernetes](./artemis/) for demo purposes.
\ No newline at end of file
+You can find more information about Apache Camel and Apache Camel K on the [official Camel website](https://camel.apache.org).
+
+## Before you begin
+
+Read the general instructions in the [root README.md file](/README.md) for setting up your environment and the Kubernetes cluster before looking at this example.
+
+Make sure you've read the [installation instructions](https://camel.apache.org/camel-k/latest/installation/installation.html) for your specific
+cluster before starting the example.
+
+## Additional Requirements for running this example
+
+**An AMQP Broker**: needed MoM for running the examples. For installation instructions, see [how to install a JMS/AMQP Broker on Kubernetes](./artemis/) for demo purposes.
+
+## Understanding the Example
+[`AmqpConnectionBeanProducer.java`](./AmqpConnectionBeanProducer.java) defines a route that generates a message every second and sends it to an amqp queue. \
Review Comment:
The README is already well written, but if I could add anything to it this section could be made bullet points instead of a single paragraph and it could become more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-examples] tadayosi merged pull request #55: fix and improve amqp example
Posted by GitBox <gi...@apache.org>.
tadayosi merged PR #55:
URL: https://github.com/apache/camel-k-examples/pull/55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org