You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/09/18 14:46:30 UTC

[GitHub] [iotdb] qiaojialin commented on a diff in pull request #6764: [IOTDB-3656] mpp load

qiaojialin commented on code in PR #6764:
URL: https://github.com/apache/iotdb/pull/6764#discussion_r964837455


##########
integration-test/src/main/java/org/apache/iotdb/itbase/env/BaseConfig.java:
##########
@@ -70,6 +70,10 @@ default BaseConfig setDataRegionNum(int dataRegionNum) {
     return this;
   }
 
+  default boolean isEnablePartition() {
+    return true;

Review Comment:
   return IoTDBConfig.isEnablePartition



##########
integration-test/src/main/java/org/apache/iotdb/it/env/AbstractNodeWrapper.java:
##########
@@ -174,7 +174,9 @@ public void start() {
               "-Xms200m",
               "-Xmx200m",
               "-XX:MaxDirectMemorySize=200m",
-              "-Djdk.nio.maxCachedBufferSize=262144"));
+              "-Djdk.nio.maxCachedBufferSize=262144",
+              "-cp",
+              templateNodeLibPath));

Review Comment:
   why add this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org