You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/08/22 11:41:20 UTC
[jira] [Commented] (CARBONDATA-165) Behavior need to be corrected
when fact csv have header for ALL_DICTIONARY
[ https://issues.apache.org/jira/browse/CARBONDATA-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430601#comment-15430601 ]
ASF GitHub Bot commented on CARBONDATA-165:
-------------------------------------------
GitHub user foryou2030 opened a pull request:
https://github.com/apache/incubator-carbondata/pull/82
[CARBONDATA-165] Support loading fact file with header for all dictionary
# Why raise this pr?
When fact csv already have header and giving FILEHEADER along with ALL_DICTIONARY_PATH option , header will be considered as data row , which is not correct.
FILEHEADER option must be given only when CSV do not have header . We can read the header from fact file when FILEHEADER is not given with ALL_DICTIONARY_PATH
# How to solve?
Add adapter for loading data with header. While loading fact CSV file with header, get file header from fact file instead of option("FILEHEADER") (the interface "getHeaderFormFactFile" did this)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/foryou2030/incubator-carbondata all_dict_header
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/82.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #82
----
commit 79d4b0ae87a58cd3437fc6f19bba9865afcac417
Author: foryou2030 <fo...@126.com>
Date: 2016-08-22T10:00:00Z
adapt data with header for all dictionary
----
> Behavior need to be corrected when fact csv have header for ALL_DICTIONARY
> --------------------------------------------------------------------------
>
> Key: CARBONDATA-165
> URL: https://issues.apache.org/jira/browse/CARBONDATA-165
> Project: CarbonData
> Issue Type: Bug
> Reporter: Gin-zhj
> Assignee: Gin-zhj
> Priority: Minor
>
> When fact csv already have header and giving FILEHEADER along with ALL_DICTIONARY_PATH option , header will be considered as data row , which is not correct.
> FILEHEADER option must be given only when CSV do not have header . We can read the header from fact file when FILEHEADER is not given with ALL_DICTIONARY_PATH
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)