[GitHub] [pulsar] merlimat commented on a change in pull request #12489: [Issue #12485][Python Client] cannot use any values that evaluates to False

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #12489:
URL: https://github.com/apache/pulsar/pull/12489#discussion_r736747908



##########
File path: pulsar-client-cpp/python/pulsar/schema/definition.py
##########
@@ -25,17 +25,16 @@
 
 
 def _check_record_or_field(x):
-    if (type(x) is type and not issubclass(x, Record)) \
-            and not isinstance(x, Field):
-        raise Exception('Argument ' + x + ' is not a Record or a Field')
+    if (type(x) is type and not issubclass(x, Record)) and not isinstance(x, Field):
+        raise Exception("Argument " + x + " is not a Record or a Field")
 
 
 class RecordMeta(type):
     def __new__(metacls, name, parents, dct):
-        if name != 'Record':
+        if name != "Record":

Review comment:
       Please leave the re-formatting changes for a separate PR.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org