You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@streams.apache.org by steveblackmon <gi...@git.apache.org> on 2017/01/27 22:59:31 UTC
[GitHub] incubator-streams pull request #354: STREAMS-448: TwitterTimelineProvider bu...
GitHub user steveblackmon opened a pull request:
https://github.com/apache/incubator-streams/pull/354
STREAMS-448: TwitterTimelineProvider bug fix
resolves STREAMS-448
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/steveblackmon/incubator-streams STREAMS-448
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/354.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #354
----
commit 5649ff6ff0fe7253f9a3e7ffb076b6b3be51c1c1
Author: Steve Blackmon @steveblackmon <sb...@apache.org>
Date: 2017-01-27T22:58:48Z
STREAMS-448: TwitterTimelineProvider bug fix
resolves STREAMS-448
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request #354: STREAMS-448: TwitterTimelineProvider bu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-streams/pull/354
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request #354: STREAMS-448: TwitterTimelineProvider bu...
Posted by rawkintrevo <gi...@git.apache.org>.
Github user rawkintrevo commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/354#discussion_r98307711
--- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java ---
@@ -314,11 +314,11 @@ protected void consolidateToIDs() {
for (String account : config.getInfo()) {
try {
- if (new Long(account) != null) {
+ if ( new Long(account) != null) {
--- End diff --
inconsistent use of white space.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams issue #354: STREAMS-448: TwitterTimelineProvider bug fix
Posted by rawkintrevo <gi...@git.apache.org>.
Github user rawkintrevo commented on the issue:
https://github.com/apache/incubator-streams/pull/354
PR looks good, two style comments. other than that, lgtm.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request #354: STREAMS-448: TwitterTimelineProvider bu...
Posted by rawkintrevo <gi...@git.apache.org>.
Github user rawkintrevo commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/354#discussion_r98307725
--- Diff: streams-contrib/streams-provider-twitter/src/test/resources/TwitterTimelineProviderIT.conf ---
@@ -16,6 +16,6 @@
# under the License.
twitter.info = [
- 18055613
+ "TheASF"
]
twitter.max_items = 1000
--- End diff --
New line at EOF
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---