You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@couchdb.apache.org by ja...@apache.org on 2022/10/17 19:53:44 UTC
[couchdb] branch main updated: Make test prometheus port explicit
This is an automated email from the ASF dual-hosted git repository.
jaydoane pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/couchdb.git
The following commit(s) were added to refs/heads/main by this push:
new e2d88138b Make test prometheus port explicit
e2d88138b is described below
commit e2d88138b0455898a594b1e45b2bdf3a74533203
Author: Jay Doane <ja...@apache.org>
AuthorDate: Sat Oct 15 17:23:51 2022 -0700
Make test prometheus port explicit
These tests currently pass without this config parameter being set
because it gets that configuration from a test template. However, this
is fragile, and it's better practice to keep everything in one place.
This makes the configuration explicit.
---
src/couch_prometheus/test/eunit/couch_prometheus_e2e_tests.erl | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/couch_prometheus/test/eunit/couch_prometheus_e2e_tests.erl b/src/couch_prometheus/test/eunit/couch_prometheus_e2e_tests.erl
index 160c1bea7..027402b51 100644
--- a/src/couch_prometheus/test/eunit/couch_prometheus_e2e_tests.erl
+++ b/src/couch_prometheus/test/eunit/couch_prometheus_e2e_tests.erl
@@ -81,6 +81,7 @@ setup_prometheus(WithAdditionalPort) ->
WithAdditionalPort,
Persist
),
+ ok = config:set("prometheus", "port", ?PROM_PORT, Persist),
% It's already started by default, so restart to pick up config
ok = application:stop(couch_prometheus),
ok = application:start(couch_prometheus),