You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Andrew Kennedy (JIRA)" <ji...@apache.org> on 2011/03/08 15:48:59 UTC
[jira] Created: (QPID-3127) Accept mode should be NONE for 0-10
NO_ACKNOWLEDGE subscriptions
Accept mode should be NONE for 0-10 NO_ACKNOWLEDGE subscriptions
----------------------------------------------------------------
Key: QPID-3127
URL: https://issues.apache.org/jira/browse/QPID-3127
Project: Qpid
Issue Type: Bug
Components: Java Client
Affects Versions: 0.10
Reporter: Andrew Kennedy
Assignee: Andrew Kennedy
Priority: Minor
Fix For: 0.11
When creating a subscription for a consumer in a 0-10 session, the accept mode is always set to EXPLICIT unless an unreliable connection is specified using the ADDR syntax. If a session is created as NO_ACKNOWLEDGE, the accept mode should also be NONE.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-3127) Accept mode should be NONE for 0-10
NO_ACKNOWLEDGE subscriptions
Posted by "Andrew Kennedy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-3127:
---------------------------------
Fix Version/s: 0.10
Assignee: Rajith Attapattu (was: Andrew Kennedy)
Rajith, can you check if this can be pushed to 0.10 please?
> Accept mode should be NONE for 0-10 NO_ACKNOWLEDGE subscriptions
> ----------------------------------------------------------------
>
> Key: QPID-3127
> URL: https://issues.apache.org/jira/browse/QPID-3127
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.10
> Reporter: Andrew Kennedy
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: 0.10, 0.11
>
>
> When creating a subscription for a consumer in a 0-10 session, the accept mode is always set to EXPLICIT unless an unreliable connection is specified using the ADDR syntax. If a session is created as NO_ACKNOWLEDGE, the accept mode should also be NONE.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-3127) Accept mode should be NONE for 0-10
NO_ACKNOWLEDGE subscriptions
Posted by "Rajith Attapattu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004021#comment-13004021 ]
Rajith Attapattu commented on QPID-3127:
----------------------------------------
Andrew, I see no problems pushing this to 0.10
I will include this in the list of commits to be included in the branch.
> Accept mode should be NONE for 0-10 NO_ACKNOWLEDGE subscriptions
> ----------------------------------------------------------------
>
> Key: QPID-3127
> URL: https://issues.apache.org/jira/browse/QPID-3127
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.10
> Reporter: Andrew Kennedy
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: 0.10, 0.11
>
>
> When creating a subscription for a consumer in a 0-10 session, the accept mode is always set to EXPLICIT unless an unreliable connection is specified using the ADDR syntax. If a session is created as NO_ACKNOWLEDGE, the accept mode should also be NONE.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Resolved: (QPID-3127) Accept mode should be NONE for 0-10
NO_ACKNOWLEDGE subscriptions
Posted by "Rajith Attapattu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rajith Attapattu resolved QPID-3127.
------------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.11)
There are tests that already cover the ack modes and this issue was found due to them.
The failing tests are now passing after this fix.
This fix was also ported to the 0.10 release branch.
> Accept mode should be NONE for 0-10 NO_ACKNOWLEDGE subscriptions
> ----------------------------------------------------------------
>
> Key: QPID-3127
> URL: https://issues.apache.org/jira/browse/QPID-3127
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.10
> Reporter: Andrew Kennedy
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: 0.10
>
>
> When creating a subscription for a consumer in a 0-10 session, the accept mode is always set to EXPLICIT unless an unreliable connection is specified using the ADDR syntax. If a session is created as NO_ACKNOWLEDGE, the accept mode should also be NONE.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-3127) Accept mode should be NONE for 0-10
NO_ACKNOWLEDGE subscriptions
Posted by "Rajith Attapattu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004003#comment-13004003 ]
Rajith Attapattu commented on QPID-3127:
----------------------------------------
Since you have done the work including the testing please go ahead with the commit.
I apologize for the mistake here. I should have left the NO_ACK part there for backwards compatibility.
> Accept mode should be NONE for 0-10 NO_ACKNOWLEDGE subscriptions
> ----------------------------------------------------------------
>
> Key: QPID-3127
> URL: https://issues.apache.org/jira/browse/QPID-3127
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.10
> Reporter: Andrew Kennedy
> Assignee: Andrew Kennedy
> Priority: Minor
> Fix For: 0.11
>
>
> When creating a subscription for a consumer in a 0-10 session, the accept mode is always set to EXPLICIT unless an unreliable connection is specified using the ADDR syntax. If a session is created as NO_ACKNOWLEDGE, the accept mode should also be NONE.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-3127) Accept mode should be NONE for 0-10
NO_ACKNOWLEDGE subscriptions
Posted by "Andrew Kennedy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003999#comment-13003999 ]
Andrew Kennedy commented on QPID-3127:
--------------------------------------
Thanks, although I have made the change already and am testing it just now, and will commit it as soon as all the test profiles are passing etc.
> Accept mode should be NONE for 0-10 NO_ACKNOWLEDGE subscriptions
> ----------------------------------------------------------------
>
> Key: QPID-3127
> URL: https://issues.apache.org/jira/browse/QPID-3127
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.10
> Reporter: Andrew Kennedy
> Assignee: Andrew Kennedy
> Priority: Minor
> Fix For: 0.11
>
>
> When creating a subscription for a consumer in a 0-10 session, the accept mode is always set to EXPLICIT unless an unreliable connection is specified using the ADDR syntax. If a session is created as NO_ACKNOWLEDGE, the accept mode should also be NONE.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-3127) Accept mode should be NONE for 0-10
NO_ACKNOWLEDGE subscriptions
Posted by "Rajith Attapattu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13003977#comment-13003977 ]
Rajith Attapattu commented on QPID-3127:
----------------------------------------
Andrew, I will fix this immediately.
I will also see if we can push this to 0.10 as this will be a fairly minor fix.
I do have a list of fixes that I am going to request to be included and will try to include this in that list as well.
> Accept mode should be NONE for 0-10 NO_ACKNOWLEDGE subscriptions
> ----------------------------------------------------------------
>
> Key: QPID-3127
> URL: https://issues.apache.org/jira/browse/QPID-3127
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.10
> Reporter: Andrew Kennedy
> Assignee: Andrew Kennedy
> Priority: Minor
> Fix For: 0.11
>
>
> When creating a subscription for a consumer in a 0-10 session, the accept mode is always set to EXPLICIT unless an unreliable connection is specified using the ADDR syntax. If a session is created as NO_ACKNOWLEDGE, the accept mode should also be NONE.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-3127) Accept mode should be NONE for 0-10
NO_ACKNOWLEDGE subscriptions
Posted by "Justin Ross (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004103#comment-13004103 ]
Justin Ross commented on QPID-3127:
-----------------------------------
Approved for 0.10, and with Rajith's review, ready to go.
> Accept mode should be NONE for 0-10 NO_ACKNOWLEDGE subscriptions
> ----------------------------------------------------------------
>
> Key: QPID-3127
> URL: https://issues.apache.org/jira/browse/QPID-3127
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.10
> Reporter: Andrew Kennedy
> Assignee: Rajith Attapattu
> Priority: Minor
> Fix For: 0.10, 0.11
>
>
> When creating a subscription for a consumer in a 0-10 session, the accept mode is always set to EXPLICIT unless an unreliable connection is specified using the ADDR syntax. If a session is created as NO_ACKNOWLEDGE, the accept mode should also be NONE.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org