You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "raulcd (via GitHub)" <gi...@apache.org> on 2023/06/13 14:02:20 UTC
[GitHub] [arrow] raulcd opened a new issue, #36048: [Release] Improve post-11-bump-versions.sh to avoid possible stray commits to reaching main
raulcd opened a new issue, #36048:
URL: https://github.com/apache/arrow/issues/36048
### Describe the enhancement requested
In the `post-11-bump-versions.sh` we push directly to main. I already created an issue in the past that I thought we could modify it to not push: https://github.com/apache/arrow/issues/33931
For the 12.0.1 patch release I accidentally had some issues when executing the script due to the Debian package versions failing to be updated. It was successful when I used: `BUMP_DEB_PACKAGE_NAMES=0`
When it finally executed correctly it pushed a lot of testing commits I had done locally to understand what the issue was plus some stray commits from previous executions as seen here:
https://github.com/apache/arrow/compare/f08670bd20e81ae79f33e66256927f584ae62d02...e53db939bfad2f20e332172ab4f453add1dc680d
As seen on those commits I pushed a new commit reverting the bad ones.
In order to avoid this from happening in the future we could:
* Validate when executing the script that local history does not differ from upstream. There are no stray commits.
* Do not push directly but show the command and prompt to push, asking the user to validate history before pushing.
### Component(s)
Developer Tools, Release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on issue #36048: [Release] Improve post-11-bump-versions.sh to avoid possible stray commits to reaching main
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on issue #36048:
URL: https://github.com/apache/arrow/issues/36048#issuecomment-1590862905
> Do you still have a log of the failure?
Yes:
```
$ dev/release/post-11-bump-versions.sh 12.0.1 13.0.0
Updating local default branch
Fetching origin
Fetching upstream
Fetching apache
From github.com:raulcd/arrow
t [tag update] apache-arrow-9.0.0 -> apache-arrow-9.0.0
Already on 'main'
Successfully rebased and updated refs/heads/main.
Updating .deb package names for 13.0.0
fatal: destination 'dev/tasks/linux-packages/apache-arrow/debian/libparquet-glib1300.install' is not a directory
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #36048: [Release] Improve post-11-bump-versions.sh to avoid possible stray commits to reaching main
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #36048:
URL: https://github.com/apache/arrow/issues/36048#issuecomment-1590035293
> For the 12.0.1 patch release I accidentally had some issues when executing the script due to the Debian package versions failing to be updated.
Do you still have a log of the failure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #36048: [Release] Improve post-11-bump-versions.sh to avoid possible stray commits to reaching main
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #36048:
URL: https://github.com/apache/arrow/issues/36048#issuecomment-1592490083
Thanks.
Fix for it: #36083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on issue #36048: [Release] Improve post-11-bump-versions.sh to avoid possible stray commits to reaching main
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on issue #36048:
URL: https://github.com/apache/arrow/issues/36048#issuecomment-1590029361
> Validate when executing the script that local history does not differ from upstream. There are no stray commits.
I prefer this approach. Because another approach needs a human operation. A human operation sometimes failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Release] Improve post-11-bump-versions.sh to avoid possible stray commits to reaching main [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #36048:
URL: https://github.com/apache/arrow/issues/36048#issuecomment-3921754784
This issue has been marked as stale because it has had no activity in the past 2 years. Please remove the stale label or comment below, or this issue will be closed in 14 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org