You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2023/01/06 09:26:22 UTC
[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1376: JAMES-3756 Show the list of accounts being delegated accounts in JMAP session
quantranhong1999 commented on code in PR #1376:
URL: https://github.com/apache/james-project/pull/1376#discussion_r1063270000
##########
server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/SessionRoutesContract.scala:
##########
@@ -132,6 +132,7 @@ object SessionRoutesContract {
| "urn:ietf:params:jmap:mdn": "29883977c13473ae7cb7678ef767cbfbaffc8a44a6e463d971d23a65c1dc4af6"
| },
| "username" : "bob@domain.tld",
+ | "delegatedUsers": [],
Review Comment:
I think we should return delegated accounts in `accounts` properties instead of inventing a new property which not in JMAP spec.
rf: https://jmap.io/spec-core.html#the-jmap-session-resource
https://github.com/apache/james-project/blob/db2f11c4db017f8544c2dac2afe27b75af077841/server/protocols/jmap-rfc-8621/doc/specs/spec/mail/delegation.mdown#addition-to-the-session-object
##########
server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/pom.xml:
##########
@@ -50,6 +50,10 @@
<groupId>${james.groupId}</groupId>
<artifactId>james-server-guice-smtp</artifactId>
</dependency>
+ <dependency>
+ <groupId>${james.groupId}</groupId>
+ <artifactId>james-server-guice-webadmin</artifactId>
Review Comment:
IMO we can just write a DelegationProbe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org