You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by nielsbasjes <gi...@git.apache.org> on 2014/03/24 20:17:48 UTC
[GitHub] incubator-storm pull request: Spouts and Bolts with whitespace in ...
GitHub user nielsbasjes opened a pull request:
https://github.com/apache/incubator-storm/pull/52
Spouts and Bolts with whitespace in name can be viewed in ui
If you run a topology with a spout or bolt that contains a whitespace in the name (i.e. "Do some thing") then the URL towards the component page will look something like this:
/topology/TOPONAME-12-12345678/component/Do+some+thing
The page that is opened on that link will try to show a component called
Do+some+thing
which it doesn't have.
This fix is a simple URL decoding step for just the component field.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nielsbasjes/incubator-storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/52.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #52
----
commit 813952a8b1345586e53da62d1d65546c15d9e120
Author: Niels Basjes <nb...@bol.com>
Date: 2014-03-24T19:06:51Z
Bolt with whitespace in name can be viewed in ui
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Spouts and Bolts with whitespace in ...
Posted by nielsbasjes <gi...@git.apache.org>.
Github user nielsbasjes commented on the pull request:
https://github.com/apache/incubator-storm/pull/52#issuecomment-38501449
The same problem exists for the topology id (I used "Evil <Hacker>" ).
I think the above code solves it because everything worked as expected with the above topology name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Spouts and Bolts with whitespace in ...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/incubator-storm/pull/52#issuecomment-38495149
Yes, that's what I meant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-275 Topologies, Spouts and Bol...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/incubator-storm/pull/52#issuecomment-40016242
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-275 Topologies, Spouts and Bol...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/52#issuecomment-39871741
I ran a few manual tests and submitted some oddly names topologies/components, and they all seem to be coming out OK. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Spouts and Bolts with whitespace in ...
Posted by nielsbasjes <gi...@git.apache.org>.
Github user nielsbasjes commented on the pull request:
https://github.com/apache/incubator-storm/pull/52#issuecomment-38492705
I assume you mean to avoid people inserting random html/javascript into these pages by choosing a 'creative' bolt name? Or did I misunderstand what you meant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Spouts and Bolts with whitespace in ...
Posted by nielsbasjes <gi...@git.apache.org>.
Github user nielsbasjes commented on the pull request:
https://github.com/apache/incubator-storm/pull/52#issuecomment-38501630
P.S. This is my first clojure code ever. So please do a good review of this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-275 Topologies, Spouts and Bol...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-storm/pull/52
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: [STORM-275] Topologies, Spouts and B...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/52#issuecomment-39786569
The code change looks fine to me. I'd like to test it out a bit before I give it a +1 though. If you remove the brackets around STORM-275 in the name of the pull request I think it will get linked up to the JIRA and comments will start to be replicated there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Spouts and Bolts with whitespace in ...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/incubator-storm/pull/52#issuecomment-38491379
Good catch. We want to make sure to escape the html too, if we decode it. You can use `escape-html` for that, as it's already in the namespace.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-275 Topologies, Spouts and Bol...
Posted by nielsbasjes <gi...@git.apache.org>.
Github user nielsbasjes commented on the pull request:
https://github.com/apache/incubator-storm/pull/52#issuecomment-39787091
Brackets in pull request name have been removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---