You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/04/16 21:01:12 UTC

[GitHub] [trafficserver] bneradt commented on a change in pull request #7711: Provide macros for easy logging of string_view/TextView values.

bneradt commented on a change in pull request #7711:
URL: https://github.com/apache/trafficserver/pull/7711#discussion_r615119967



##########
File path: include/tscore/Diags.h
##########
@@ -194,3 +194,17 @@ extern inkcoreapi Diags *diags;
 #define is_diags_on(_t) 0
 
 #endif // TS_USE_DIAGS
+
+#if !defined(TS_SVP)
+
+// Macros for convinient output of string_view (and thus also ts::TextView) instances using printf-like
+// functions.
+//
+#define TS_SVPF "%.*s"

Review comment:
       This functions kind of like the `PRIuMAX` and related types, right? Maybe call this TS_PRIsv?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org