You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/04 08:08:28 UTC

[GitHub] [spark] sarutak opened a new pull request #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

sarutak opened a new pull request #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787
 
 
   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   ExecutorsPage shows resource information even in local mode.
   It's done by changing `LocalSchedulerBackend` to receive resource information.
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   It's useful to confirm resource information assigned from WebUI especially during application development.
   
   ### Does this PR introduce any user-facing change?
   <!--
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If no, write 'No'.
   -->
   Yes.
   Following is the screenshot before this change applied.
   ![local-backend-before](https://user-images.githubusercontent.com/4736016/75857831-43fd2880-5e3a-11ea-903d-76957db6447b.png)
   
   And this is after this change applied.
   ![local-backend-after](https://user-images.githubusercontent.com/4736016/75857867-57a88f00-5e3a-11ea-84e8-8cc518dcf661.png)
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   Manually tested using following configurations.
   
   * spark.driver.resourcesFile=/path/to/rsourceFile
   * spark.driver.resource.gpu.amount=1
   * spark.driver.resource.gpu.vendor=nvidia
   
   The content of the resourceFile is like as follows.
   `[{"id": {"componentName": "spark.driver", "resourceName": "gpu"}, "addresses":["0"]}]`
   
   And launched spark-shell and then, confirmed ExecutorsPage.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] sarutak commented on a change in pull request #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#discussion_r387539932
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/SparkContext.scala
 ##########
 @@ -2788,7 +2788,7 @@ object SparkContext extends Logging {
       case "local" =>
         checkResourcesPerTask(1)
         val scheduler = new TaskSchedulerImpl(sc, MAX_LOCAL_TASK_FAILURES, isLocal = true)
-        val backend = new LocalSchedulerBackend(sc.getConf, scheduler, 1)
+        val backend = new LocalSchedulerBackend(sc.getConf, scheduler, 1, sc._resources)
 
 Review comment:
   Ah, right. I'll also fix it. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] sarutak commented on a change in pull request #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#discussion_r387517719
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/SparkContext.scala
 ##########
 @@ -2788,7 +2788,7 @@ object SparkContext extends Logging {
       case "local" =>
         checkResourcesPerTask(1)
         val scheduler = new TaskSchedulerImpl(sc, MAX_LOCAL_TASK_FAILURES, isLocal = true)
-        val backend = new LocalSchedulerBackend(sc.getConf, scheduler, 1)
+        val backend = new LocalSchedulerBackend(sc.getConf, scheduler, 1, sc._resources)
 
 Review comment:
   > sc._resources is for driver rather than executor?
   Yes. But in local mode, `driver` is behave as `executor` and `spark.executor.resource.*` doesn't affect.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] tgravescs commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
tgravescs commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#issuecomment-594646618
 
 
   I"m confused by the description of this. local mode doesn't support custom resource scheduling

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#issuecomment-594485479
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#issuecomment-594382698
 
 
   **[Test build #119286 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119286/testReport)** for PR 27787 at commit [`78e172e`](https://github.com/apache/spark/commit/78e172e5eaa8085e620236dc90d0ee8a1fb11da4).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#issuecomment-594383172
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24026/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#issuecomment-594382698
 
 
   **[Test build #119286 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119286/testReport)** for PR 27787 at commit [`78e172e`](https://github.com/apache/spark/commit/78e172e5eaa8085e620236dc90d0ee8a1fb11da4).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] sarutak commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
sarutak commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#issuecomment-594652204
 
 
   I'll close this PR because resource-aware scheduling doesn't support local mode.
   I'll open another PR for supporting local mode later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] tgravescs commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
tgravescs commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#issuecomment-594692839
 
 
   what is the use case for this in local mode? If you are just running on a single box you would generally have visibility into all the resources on the node

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#issuecomment-594485479
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Ngone51 commented on a change in pull request #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#discussion_r387531600
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/SparkContext.scala
 ##########
 @@ -2788,7 +2788,7 @@ object SparkContext extends Logging {
       case "local" =>
         checkResourcesPerTask(1)
         val scheduler = new TaskSchedulerImpl(sc, MAX_LOCAL_TASK_FAILURES, isLocal = true)
-        val backend = new LocalSchedulerBackend(sc.getConf, scheduler, 1)
+        val backend = new LocalSchedulerBackend(sc.getConf, scheduler, 1, sc._resources)
 
 Review comment:
   I see. But we also need to pass `_resources` into `LocalEndpoint` and then to `Executor`, not only UI?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] sarutak commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
sarutak commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#issuecomment-594718940
 
 
   Sometimes application developers develop apps on their laptops and test functionality on it and then, deploy the apps to a cluster.
   So if resource aware scheduling supports local mode, they can deploy apps without code change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#issuecomment-594383164
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#issuecomment-594383164
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#issuecomment-594484312
 
 
   **[Test build #119286 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119286/testReport)** for PR 27787 at commit [`78e172e`](https://github.com/apache/spark/commit/78e172e5eaa8085e620236dc90d0ee8a1fb11da4).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Ngone51 commented on a change in pull request #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#discussion_r387510949
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/SparkContext.scala
 ##########
 @@ -2788,7 +2788,7 @@ object SparkContext extends Logging {
       case "local" =>
         checkResourcesPerTask(1)
         val scheduler = new TaskSchedulerImpl(sc, MAX_LOCAL_TASK_FAILURES, isLocal = true)
-        val backend = new LocalSchedulerBackend(sc.getConf, scheduler, 1)
+        val backend = new LocalSchedulerBackend(sc.getConf, scheduler, 1, sc._resources)
 
 Review comment:
   `sc._resources` is for `driver` rather than `executor`? 
   
   I know that `driver` and `executor` are in the same JVM in this case, but we also have separate resource configurations for `executor.` 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#issuecomment-594383172
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24026/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] sarutak commented on a change in pull request #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
sarutak commented on a change in pull request #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#discussion_r387517719
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/SparkContext.scala
 ##########
 @@ -2788,7 +2788,7 @@ object SparkContext extends Logging {
       case "local" =>
         checkResourcesPerTask(1)
         val scheduler = new TaskSchedulerImpl(sc, MAX_LOCAL_TASK_FAILURES, isLocal = true)
-        val backend = new LocalSchedulerBackend(sc.getConf, scheduler, 1)
+        val backend = new LocalSchedulerBackend(sc.getConf, scheduler, 1, sc._resources)
 
 Review comment:
   > sc._resources is for driver rather than executor?
   
   Yes. But in local mode, `driver` is behave as `executor` and `spark.executor.resource.*` doesn't affect.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Ngone51 commented on a change in pull request #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#discussion_r387510949
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/SparkContext.scala
 ##########
 @@ -2788,7 +2788,7 @@ object SparkContext extends Logging {
       case "local" =>
         checkResourcesPerTask(1)
         val scheduler = new TaskSchedulerImpl(sc, MAX_LOCAL_TASK_FAILURES, isLocal = true)
-        val backend = new LocalSchedulerBackend(sc.getConf, scheduler, 1)
+        val backend = new LocalSchedulerBackend(sc.getConf, scheduler, 1, sc._resources)
 
 Review comment:
   `sc._resources` is for `driver` rather than `executor`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] sarutak closed pull request #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
sarutak closed pull request #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] sarutak commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
sarutak commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#issuecomment-594640524
 
 
   I've noticed that resource-aware scheduling doesn't support local mode so I'll work on that.
   I'll also change the title and description of this PR and JIRA later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#issuecomment-594485488
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119286/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Ngone51 commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#issuecomment-594637947
 
 
   cc @jiangxb1987 @tgravescs 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#issuecomment-594485488
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119286/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] jiangxb1987 commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
jiangxb1987 commented on issue #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#issuecomment-594717644
 
 
   @sarutak So you have a use case that is running production workload on local mode?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Ngone51 commented on a change in pull request #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #27787: [SPARK-31035][WEBUI] Show assigned resource information for local mode
URL: https://github.com/apache/spark/pull/27787#discussion_r387532582
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/SparkContext.scala
 ##########
 @@ -2788,7 +2788,7 @@ object SparkContext extends Logging {
       case "local" =>
         checkResourcesPerTask(1)
         val scheduler = new TaskSchedulerImpl(sc, MAX_LOCAL_TASK_FAILURES, isLocal = true)
-        val backend = new LocalSchedulerBackend(sc.getConf, scheduler, 1)
+        val backend = new LocalSchedulerBackend(sc.getConf, scheduler, 1, sc._resources)
 
 Review comment:
   Maybe we should do `parseOrFindResources` for `executor` in `LocalSchedulerBackend` and then we could get the real resources which configured from `executor`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org