[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2340: [WIP][KYUUBI #2021] Command OptionParser for launching Hive Backend Engine

[GitBox <gi...@apache.org>]

yaooqinn commented on PR #2340:
URL: https://github.com/apache/incubator-kyuubi/pull/2340#issuecomment-1096900579

   you are in a wrong way.  the option parser only need to parse args passed to XXXEngine.main. these args are all in the strict form of --conf key=val. the option parser parser them and set key-value to kyuubi conf and engine confs such as hive conf. the implantation then can be engine independent which could be placed in kyuubi common module or somewhere else.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org