You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/01 03:08:14 UTC
[GitHub] [kafka] showuon opened a new pull request #11160: MINOR: update batch.size doc
showuon opened a new pull request #11160:
URL: https://github.com/apache/kafka/pull/11160
Found we didn't mention anything about the `linger.ms` and upper bound batch size concept in the `batch.size`, which will lead users believe we'll send every batch with this `batch.size` setting value.
**before**:
**after**:
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #11160: MINOR: update batch.size doc
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #11160:
URL: https://github.com/apache/kafka/pull/11160#discussion_r680443544
##########
File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##########
@@ -106,7 +111,7 @@
private static final String LINGER_MS_DOC = "The producer groups together any records that arrive in between request transmissions into a single batched request. "
+ "Normally this occurs only under load when records arrive faster than they can be sent out. However in some circumstances the client may want to "
+ "reduce the number of requests even under moderate load. This setting accomplishes this by adding a small amount "
- + "of artificial delay—that is, rather than immediately sending out a record the producer will wait for up to "
+ + "of artificial delay—that is, rather than immediately sending out a record, the producer will wait for up to "
Review comment:
add a comma for better readability:
before:
`that is, rather than immediately sending out a record the producer will wait for up to the given delay to allow other records to be sent so that the sends can be batched together.`
after:
`that is, rather than immediately sending out a record[,] the producer will wait for up to the given delay to allow other records to be sent so that the sends can be batched together.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] abbccdda merged pull request #11160: MINOR: update batch.size doc
Posted by GitBox <gi...@apache.org>.
abbccdda merged pull request #11160:
URL: https://github.com/apache/kafka/pull/11160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org