You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/25 14:48:57 UTC
[GitHub] [airflow] Bowrna opened a new pull request, #24173: slack new system test - AIP 47
Bowrna opened a new pull request, #24173:
URL: https://github.com/apache/airflow/pull/24173
closes: #22465
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna closed pull request #24173: slack new system test - AIP 47
Posted by GitBox <gi...@apache.org>.
Bowrna closed pull request #24173: slack new system test - AIP 47
URL: https://github.com/apache/airflow/pull/24173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #24173: slack new system test - AIP 47
Posted by GitBox <gi...@apache.org>.
Bowrna commented on PR #24173:
URL: https://github.com/apache/airflow/pull/24173#issuecomment-1146523948
Raised PR without noticing that already one PR is raised for this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna closed pull request #24173: slack new system test - AIP 47
Posted by GitBox <gi...@apache.org>.
Bowrna closed pull request #24173: slack new system test - AIP 47
URL: https://github.com/apache/airflow/pull/24173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #24173: slack new system test - AIP 47
Posted by GitBox <gi...@apache.org>.
Bowrna commented on PR #24173:
URL: https://github.com/apache/airflow/pull/24173#issuecomment-1194157146
I have closed this PR as there was another PR https://github.com/apache/airflow/pull/23848 that solves this issue. But as that issue is inactive and I have partially started this solution, I thought I could reopen it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #24173: slack new system test - AIP 47
Posted by GitBox <gi...@apache.org>.
potiuk commented on code in PR #24173:
URL: https://github.com/apache/airflow/pull/24173#discussion_r929820881
##########
docs/apache-airflow-providers-slack/index.rst:
##########
@@ -44,7 +44,7 @@ Content
Connection Types <connections/slack>
Python API <_api/airflow/providers/slack/index>
- Example DAGs <https://github.com/apache/airflow/tree/providers-slack/5.0.0/tests/system/providers/slack>
Review Comment:
I think that was fine. All the other providers use it and we are (I believe automatically updating those).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org