[GitHub] [ozone] adoroszlai commented on a change in pull request #2549: HDDS-5604. Intermittent failure in TestPipelineClose.

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #2549:
URL: https://github.com/apache/ozone/pull/2549#discussion_r692145103



##########
File path: hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestPipelineClose.java
##########
@@ -242,7 +238,7 @@ public void testPipelineCloseWithLogFailure() throws IOException {
     xceiverRatis.handleNodeLogFailure(groupId, null);
 
     // verify SCM receives a pipeline action report "immediately"
-    Mockito.verify(pipelineActionTest, Mockito.timeout(100))
+    Mockito.verify(pipelineActionTest, Mockito.timeout(500))

Review comment:
       > Should the conf not be set before the MiniOzoneCluster.build() method is called?
   
   With 1s timeout it seems to work fine both with and without that change (tested 3-400 repetitions).
   
   https://github.com/adoroszlai/hadoop-ozone/commits/HDDS-5604-repeat (`build()` moved after conf is set)
   https://github.com/adoroszlai/hadoop-ozone/commits/HDDS-5604-repro-1000 (`build()` in original order)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org