You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apreq-dev@httpd.apache.org by Matt Sergeant <ma...@sergeant.org> on 2001/02/14 15:32:21 UTC
Sun Workshop C compilation patch
Index: c/apache_multipart_buffer.c
===================================================================
RCS file: /home/cvs/httpd-apreq/c/apache_multipart_buffer.c,v
retrieving revision 1.4
diff -r1.4 apache_multipart_buffer.c
67c67
< void* my_memstr(void* haystack, int haystacklen, const char* needle,
---
> void* my_memstr(char* haystack, int haystacklen, const char* needle,
72c72
< unsigned char *ptr = haystack;
---
> char *ptr = haystack;
77c77
< len = haystacklen - (ptr - (unsigned char *)haystack);
---
> len = haystacklen - (ptr - (char *)haystack);
--
<Matt/>
/|| ** Founder and CTO ** ** http://axkit.com/ **
//|| ** AxKit.com Ltd ** ** XML Application Serving **
// || ** http://axkit.org ** ** XSLT, XPathScript, XSP **
// \\| // ** mod_perl news and resources: http://take23.org **
\\//
//\\
// \\
Re: Sun Workshop C compilation patch
Posted by Matt Sergeant <ma...@sergeant.org>.
On 24 Feb 2001, Joe Schaefer wrote:
> btw- the other patch you posted looked good to me.
OK, I applied my earlier patch.
--
<Matt/>
/|| ** Director and CTO **
//|| ** AxKit.com Ltd ** ** XML Application Serving **
// || ** http://axkit.org ** ** XSLT, XPathScript, XSP **
// \\| // ** Personal Web Site: http://sergeant.org/ **
\\//
//\\
// \\
Re: Sun Workshop C compilation patch
Posted by Joe Schaefer <jo...@sunstarsys.com>.
Matt Sergeant <ma...@sergeant.org> writes:
> On 20 Feb 2001, David N. Welton wrote:
>
> >
> > A mod_dtcl user sent me this. Why are these included but not used?
> >
> > --- apache_multipart_buffer.c~ Mon Feb 19 19:37:57 2001
> > +++ apache_multipart_buffer.c Mon Feb 19 19:38:55 2001
> > @@ -182,7 +182,6 @@
> > /* finds a boundary */
> > int find_boundary(multipart_buffer *self, char *boundary)
> > {
> > - int len, bound_len = strlen(boundary);
> > char *line;
> >
> > /* loop thru lines */
>
> No idea...
>
> BTW: since nobody responded to my last patch, or this one, I'm thinking of
> just commiting the patches. Does anyone have any immediate worry about
> that?
No, but I'd rather patch the whole thing with the code I wrote using
the list.c,h stuff and building from there instead. But since there's
no consensus regarding whether or not it's a good idea, I've been
keeping quiet about it.
btw- the other patch you posted looked good to me.
--
Joe Schaefer
joe@sunstarsys.com
Re: Sun Workshop C compilation patch
Posted by Matt Sergeant <ma...@sergeant.org>.
On 20 Feb 2001, David N. Welton wrote:
>
> A mod_dtcl user sent me this. Why are these included but not used?
>
> --- apache_multipart_buffer.c~ Mon Feb 19 19:37:57 2001
> +++ apache_multipart_buffer.c Mon Feb 19 19:38:55 2001
> @@ -182,7 +182,6 @@
> /* finds a boundary */
> int find_boundary(multipart_buffer *self, char *boundary)
> {
> - int len, bound_len = strlen(boundary);
> char *line;
>
> /* loop thru lines */
No idea...
BTW: since nobody responded to my last patch, or this one, I'm thinking of
just commiting the patches. Does anyone have any immediate worry about
that?
--
<Matt/>
/|| ** Founder and CTO ** ** http://axkit.com/ **
//|| ** AxKit.com Ltd ** ** XML Application Serving **
// || ** http://axkit.org ** ** XSLT, XPathScript, XSP **
// \\| // ** mod_perl news and resources: http://take23.org **
\\//
//\\
// \\
Re: Sun Workshop C compilation patch
Posted by "David N. Welton" <da...@apache.org>.
A mod_dtcl user sent me this. Why are these included but not used?
--- apache_multipart_buffer.c~ Mon Feb 19 19:37:57 2001
+++ apache_multipart_buffer.c Mon Feb 19 19:38:55 2001
@@ -182,7 +182,6 @@
/* finds a boundary */
int find_boundary(multipart_buffer *self, char *boundary)
{
- int len, bound_len = strlen(boundary);
char *line;
/* loop thru lines */
--
David N. Welton
Personal: http://www.efn.org/~davidw/
Free Software: http://people.debian.org/~davidw/
Apache Tcl: http://tcl.apache.org