You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2018/09/26 12:36:56 UTC

[GitHub] tinkerpop pull request #941: TINKERPOP-2040 Improve flexibility of GroovyTra...

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/941

    TINKERPOP-2040 Improve flexibility of GroovyTranslator to handle custom types

    https://issues.apache.org/jira/browse/TINKERPOP-2040
    
    Handled all of the core GraphSON types in the `GroovyTranslator`. Included a new `TypeTranslator` to allow the behavior of the `ScriptTranslator` to be modified and allowed the `GremlinGroovyScriptEngine` to accept a `TranslatorCustomizer` to allow that custom `TypeTranslator` to be used.
    
    All tests pass with `docker/build.sh -t -i`
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-2040

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/941.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #941
    
----
commit b33c8c683d7e95cfccae07b20dccf54a83b5eba0
Author: Stephen Mallette <sp...@...>
Date:   2018-09-20T15:53:07Z

    TINKERPOP-2040 Provide improved type handling for GroovyTranslator
    
    Refactored testing and added support for UUID, Date, Timestamp as well as a method to override standard type handling.

commit 873609bcb23552d033de91282bde3705f729fdc2
Author: Stephen Mallette <sp...@...>
Date:   2018-09-25T17:46:38Z

    TINKERPOP-2040 Added more tests to cover more GraphSON types

commit 93d99ef1a0119b4c0994daeccaf312d45c894f45
Author: Stephen Mallette <sp...@...>
Date:   2018-09-25T21:29:49Z

    TINKERPOP-2040 Hooked up Customizer for TypeTranslator
    
    Enables the Groovy GremlinScriptEngine to use custom TypeTranslators

----


---

[GitHub] tinkerpop issue #941: TINKERPOP-2040 Improve flexibility of GroovyTranslator...

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/941
  
    Added the changelog entry. Didn't do upgrade notes because this is a relatively deep in the weeds sorta capability. If you think it's really necessary I can write some up though.


---

[GitHub] tinkerpop issue #941: TINKERPOP-2040 Improve flexibility of GroovyTranslator...

Posted by robertdale <gi...@git.apache.org>.

Github user robertdale commented on the issue:

    https://github.com/apache/tinkerpop/pull/941
  
    VOTE +1


---

[GitHub] tinkerpop pull request #941: TINKERPOP-2040 Improve flexibility of GroovyTra...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tinkerpop/pull/941


---

[GitHub] tinkerpop issue #941: TINKERPOP-2040 Improve flexibility of GroovyTranslator...

Posted by robertdale <gi...@git.apache.org>.

Github user robertdale commented on the issue:

    https://github.com/apache/tinkerpop/pull/941
  
    @spmallette Should have a CHANGELOG entry if not also an upgrade release note.


---

[GitHub] tinkerpop issue #941: TINKERPOP-2040 Improve flexibility of GroovyTranslator...

Posted by dkuppitz <gi...@git.apache.org>.

Github user dkuppitz commented on the issue:

    https://github.com/apache/tinkerpop/pull/941
  
    VOTE +1


---