[GitHub] [airflow] mik-laj commented on a change in pull request #12712: AWS Hook - allow IDP HTTP retry (#12639)

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #12712:
URL: https://github.com/apache/airflow/pull/12712#discussion_r553846178



##########
File path: tests/providers/amazon/aws/hooks/test_base_aws.py
##########
@@ -252,6 +322,78 @@ def import_mock(name, *args):
             [mock.call.get_default_id_token_credentials(target_audience='aws-federation.airflow.apache.org')]
         )
 
+    @unittest.skipIf(mock_sts is None, 'mock_sts package not present')
+    @mock.patch.object(AwsBaseHook, 'get_connection')
+    @mock_sts
+    def test_assume_role_with_saml(self, mock_get_connection):

Review comment:
       The title of this PR uses the word "Retry", but I don't see this word appearing in the tests. Does this code test the same functionality?

##########
File path: tests/providers/amazon/aws/hooks/test_base_aws.py
##########
@@ -252,6 +322,78 @@ def import_mock(name, *args):
             [mock.call.get_default_id_token_credentials(target_audience='aws-federation.airflow.apache.org')]
         )
 
+    @unittest.skipIf(mock_sts is None, 'mock_sts package not present')
+    @mock.patch.object(AwsBaseHook, 'get_connection')
+    @mock_sts
+    def test_assume_role_with_saml(self, mock_get_connection):

Review comment:
       The title of this PR uses the word "Retry", but I don't see this word appearing in this code. Does this code test the same functionality?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org