You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "sdedic (via GitHub)" <gi...@apache.org> on 2023/09/18 12:50:07 UTC
[GitHub] [netbeans] sdedic opened a new pull request, #6464: Avoid double quoting extra path
sdedic opened a new pull request, #6464:
URL: https://github.com/apache/netbeans/pull/6464
When the extension resides in a directory with path in space, NBLS does not start properly. It does in a basic configuration, but when another extension contributes an additional module, the passed parameter, `-J-Dnetbeans.extra.dirs=` will not be passed properly.
During testing, the arguments passed to the `nbcode` launcher are (logged from `nbcode.ts`)
```
[Extension Host] Launching NBLS with arguments: --userdir,/space/tmp/test mezera 8/user/User/workspaceStorage/bb81367d8526610b14dd61e6f4fb379f/asf.apache-netbeans-java/userdir,--jdkhome,/space/java/current,-J-Dnetbeans.extra.dirs="/space/tmp/test mezera 8/ext/oracle-labs-graalvm.micronaut-tools-0.6.0-208/nbcode/graalvmextra",--modules,--list,-J-XX:PerfMaxStringConstLength=10240,--laf,com.formdev.flatlaf.FlatDarkLaf,--direct-disable,org.netbeans.modules.nbcode.integration.java
```
But when the launcher invokes `nbexec`, the arguments are:
```
Using args: "--jdkhome" "/space/java/current" "-J-Dnetbeans.extra.dirs="/space/tmp/test mezera 8/ext/oracle-labs-graalvm.micronaut-tools-0.6.0-208/nbcode/graalvmextra"" "--modules" "--list" "-J-XX:PerfMaxStringConstLength=10240" "--laf" "com.formdev.flatlaf.FlatDarkLaf" "--direct-disable" "org.netbeans.modules.nbcode.integration.java"
```
Note the double quoting: Entire parameter is enclosed in quotes, then part of the parameter is. After this point, the unquoting will split the parameters in 3 parts.
The fix is simple: as the arguments are passed to system call, rather than some shell thing, parameters do not need to be quoted ... so I've removed the quotes.
Seems to work OK on Windows, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #6464: Avoid double quoting extra path
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic merged PR #6464:
URL: https://github.com/apache/netbeans/pull/6464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists