You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/11/02 17:38:19 UTC
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #6217: Traffic Stats logging use lib/go-log
ocket8888 commented on a change in pull request #6217:
URL: https://github.com/apache/trafficcontrol/pull/6217#discussion_r741322843
##########
File path: traffic_stats/traffic_stats.go
##########
@@ -131,24 +224,24 @@ func main() {
tickers = setTimers(config)
termChan := make(chan os.Signal, 1)
- signal.Notify(termChan, syscall.SIGKILL, syscall.SIGINT, syscall.SIGTERM, syscall.SIGQUIT)
+ signal.Notify(termChan, syscall.SIGINT, syscall.SIGTERM, syscall.SIGQUIT)
Review comment:
Programs can't actually catch SIGKILL, so it was unnecessary at best, misleading at worst.
##########
File path: traffic_stats/traffic_stats.go
##########
@@ -131,24 +224,24 @@ func main() {
tickers = setTimers(config)
termChan := make(chan os.Signal, 1)
- signal.Notify(termChan, syscall.SIGKILL, syscall.SIGINT, syscall.SIGTERM, syscall.SIGQUIT)
+ signal.Notify(termChan, syscall.SIGINT, syscall.SIGTERM, syscall.SIGQUIT)
Review comment:
Programs can't actually catch SIGKILL, so it was unnecessary at best, misleading at worst.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org