You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2015/06/25 17:19:27 UTC

svn commit: r1687551 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

Author: markt
Date: Thu Jun 25 15:19:27 2015
New Revision: 1687551

URL: http://svn.apache.org/r1687551
Log:
More false positives

Modified:
    tomcat/trunk/res/findbugs/filter-false-positives.xml

Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/res/findbugs/filter-false-positives.xml?rev=1687551&r1=1687550&r2=1687551&view=diff
==============================================================================
--- tomcat/trunk/res/findbugs/filter-false-positives.xml (original)
+++ tomcat/trunk/res/findbugs/filter-false-positives.xml Thu Jun 25 15:19:27 2015
@@ -316,6 +316,18 @@
     <Bug code="Nm" />
   </Match>
   <Match>
+    <!-- Return value is never used -->
+    <Class name="org.apache.tomcat.dbcp.dbcp2.DelegatingConnection" />
+    <Method name="prepareStatement" />
+    <Bug pattern="NP_NONNULL_RETURN_VIOLATION" />
+  </Match>
+  <Match>
+    <!-- Pooled objects can't be null so this is OK -->
+    <Class name="org.apache.tomcat.dbcp.pool2.impl.BaseGenericObjectPool$IdentityWrapper" />
+    <Method name="equals" />
+    <Bug pattern="NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT" />
+  </Match>
+  <Match>
     <!-- Increment is in sync block so it is safe. Volatile is used so reading
          thread sees latest value.  -->
     <Class name="org.apache.tomcat.dbcp.pool2.impl.DefaultPooledObject" />



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org