You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "arshadmohammad (via GitHub)" <gi...@apache.org> on 2024/08/13 19:21:38 UTC
[PR] [Improvement][Seatunnel-web] Add support to execute seatunnel-web REST API e2e [seatunnel-web]
arshadmohammad opened a new pull request, #180:
URL: https://github.com/apache/seatunnel-web/pull/180
Added to support run test cases in live seatunnel and seatunnel-web. Please go through seatunnel-web-it/README.md to know how to run these integration tests.
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Seatunnel-web] Add support to execute seatunnel-web REST API e2e [seatunnel-web]
Posted by "arshadmohammad (via GitHub)" <gi...@apache.org>.
arshadmohammad commented on code in PR #180:
URL: https://github.com/apache/seatunnel-web/pull/180#discussion_r1716815716
##########
seatunnel-web-it/README.md:
##########
@@ -0,0 +1,13 @@
+Build seatunnel-web
+./mvnw clean install -DskipTests
+
+Update mysql database details in src/test/resources/application.yml and Run the seatunnel-web-it integration tests
Review Comment:
Good suggestion.
Sure, we can add mysql environment in e2e test cases, but later and in separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Seatunnel-web] Add support to execute seatunnel-web REST API e2e [seatunnel-web]
Posted by "arshadmohammad (via GitHub)" <gi...@apache.org>.
arshadmohammad commented on PR #180:
URL: https://github.com/apache/seatunnel-web/pull/180#issuecomment-2288617345
Thanks @davidzollo and @hailin0 for the reviewing the PR.
Thanks @Hisoka-X for reviewing and merging the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Seatunnel-web] Add support to execute seatunnel-web REST API e2e [seatunnel-web]
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #180:
URL: https://github.com/apache/seatunnel-web/pull/180#issuecomment-2288583118
Thanks @arshadmohammad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Seatunnel-web] Add support to execute seatunnel-web REST API e2e [seatunnel-web]
Posted by "arshadmohammad (via GitHub)" <gi...@apache.org>.
arshadmohammad commented on PR #180:
URL: https://github.com/apache/seatunnel-web/pull/180#issuecomment-2287054866
Added 31 test cases also. All are passing

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Seatunnel-web] Add support to execute seatunnel-web REST API e2e [seatunnel-web]
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X merged PR #180:
URL: https://github.com/apache/seatunnel-web/pull/180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Seatunnel-web] Add support to execute seatunnel-web REST API e2e [seatunnel-web]
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #180:
URL: https://github.com/apache/seatunnel-web/pull/180#issuecomment-2288045944
Great! Thanks @arshadmohammad !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Seatunnel-web] Add support to execute seatunnel-web REST API e2e [seatunnel-web]
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #180:
URL: https://github.com/apache/seatunnel-web/pull/180#issuecomment-2288046676
Great idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Seatunnel-web] Add support to execute seatunnel-web REST API e2e [seatunnel-web]
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #180:
URL: https://github.com/apache/seatunnel-web/pull/180#discussion_r1716465642
##########
seatunnel-web-it/README.md:
##########
@@ -0,0 +1,13 @@
+Build seatunnel-web
+./mvnw clean install -DskipTests
+
+Update mysql database details in src/test/resources/application.yml and Run the seatunnel-web-it integration tests
Review Comment:
How about add mysql environment in e2e? We have some example in https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/cdc/mysql/MysqlCDCIT.java#L107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org